iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

misc: fastrpc: Fix return value check in fastrpc_map_create()

Browse Source 
In case of error, the function dma_buf_get() returns ERR_PTR() and never
returns NULL. The NULL test in the return value check should be replaced
with IS_ERR().

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2019-02-16 01:35:43 +00:00 committed by Greg Kroah-Hartman
parent 3013bf62b6
commit 682a60446b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/misc/fastrpc.c
View File

@ -496,8 +496,8 @@ static int fastrpc_map_create(struct fastrpc_user *fl, int fd,
map->fl = fl;
map->fd = fd;
map->buf = dma_buf_get(fd);
if (!map->buf) {
err = -EINVAL;
if (IS_ERR(map->buf)) {
err = PTR_ERR(map->buf);
goto get_err;
}