iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: ipa: use bitmap to check for missing regions

Browse Source 
In ipa_mem_valid(), wait until regions have been marked in the memory
region bitmap, and check all that are not found there to ensure they
are not required.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Alex Elder 2021-06-09 17:35:03 -05:00 committed by David S. Miller
parent eadf7f9376
commit 6857b02392
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/net/ipa/ipa_mem.c
View File

@ -249,19 +249,16 @@ static bool ipa_mem_valid(struct ipa *ipa, const struct ipa_mem_data *mem_data)
if (mem->offset)
dev_warn(dev, "empty region %u has non-zero offset\n",
mem_id);
if (ipa_mem_id_required(ipa, mem_id)) {
dev_err(dev, "required memory region %u missing\n",
mem_id);
return false;
}
}
/* Now see if any required regions are not defined */
while (mem_id < IPA_MEM_COUNT)
if (ipa_mem_id_required(ipa, mem_id++))
for (mem_id = find_first_zero_bit(regions, IPA_MEM_COUNT);
mem_id < IPA_MEM_COUNT;
mem_id = find_next_zero_bit(regions, IPA_MEM_COUNT, mem_id + 1)) {
if (ipa_mem_id_required(ipa, mem_id))
dev_err(dev, "required memory region %u missing\n",
mem_id);
}
return true;
}