kunit: tool: add subscripts for type annotations where appropriate
E.g. for subprocess.Popen, it can be opened in `text=True` mode where it returns strings, or `text=False` where it returns bytes. To differentiate, you can annotate types as `Popen[str]` or `Popen[bytes]`. This patch should add subscripts in all the places we were missing them. Reported-by: Johannes Berg <johannes.berg@intel.com> Link: https://lore.kernel.org/linux-kselftest/20230315105055.9b2be0153625.I7a2cb99b95dff216c0feed4604255275e0b156a7@changeid/ Signed-off-by: Daniel Latypov <dlatypov@google.com> Reviewed-by: David Gow <davidgow@google.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
This commit is contained in:
parent
2c6a96dad5
commit
695e260308
@ -92,7 +92,7 @@ class LinuxSourceTreeOperations:
|
|||||||
if stderr: # likely only due to build warnings
|
if stderr: # likely only due to build warnings
|
||||||
print(stderr.decode())
|
print(stderr.decode())
|
||||||
|
|
||||||
def start(self, params: List[str], build_dir: str) -> subprocess.Popen:
|
def start(self, params: List[str], build_dir: str) -> subprocess.Popen[str]:
|
||||||
raise RuntimeError('not implemented!')
|
raise RuntimeError('not implemented!')
|
||||||
|
|
||||||
|
|
||||||
@ -112,7 +112,7 @@ class LinuxSourceTreeOperationsQemu(LinuxSourceTreeOperations):
|
|||||||
kconfig.merge_in_entries(base_kunitconfig)
|
kconfig.merge_in_entries(base_kunitconfig)
|
||||||
return kconfig
|
return kconfig
|
||||||
|
|
||||||
def start(self, params: List[str], build_dir: str) -> subprocess.Popen:
|
def start(self, params: List[str], build_dir: str) -> subprocess.Popen[str]:
|
||||||
kernel_path = os.path.join(build_dir, self._kernel_path)
|
kernel_path = os.path.join(build_dir, self._kernel_path)
|
||||||
qemu_command = ['qemu-system-' + self._qemu_arch,
|
qemu_command = ['qemu-system-' + self._qemu_arch,
|
||||||
'-nodefaults',
|
'-nodefaults',
|
||||||
@ -141,7 +141,7 @@ class LinuxSourceTreeOperationsUml(LinuxSourceTreeOperations):
|
|||||||
kconfig.merge_in_entries(base_kunitconfig)
|
kconfig.merge_in_entries(base_kunitconfig)
|
||||||
return kconfig
|
return kconfig
|
||||||
|
|
||||||
def start(self, params: List[str], build_dir: str) -> subprocess.Popen:
|
def start(self, params: List[str], build_dir: str) -> subprocess.Popen[str]:
|
||||||
"""Runs the Linux UML binary. Must be named 'linux'."""
|
"""Runs the Linux UML binary. Must be named 'linux'."""
|
||||||
linux_bin = os.path.join(build_dir, 'linux')
|
linux_bin = os.path.join(build_dir, 'linux')
|
||||||
params.extend(['mem=1G', 'console=tty', 'kunit_shutdown=halt'])
|
params.extend(['mem=1G', 'console=tty', 'kunit_shutdown=halt'])
|
||||||
|
@ -15,7 +15,7 @@ _RESET = '\033[0;0m'
|
|||||||
class Printer:
|
class Printer:
|
||||||
"""Wraps a file object, providing utilities for coloring output, etc."""
|
"""Wraps a file object, providing utilities for coloring output, etc."""
|
||||||
|
|
||||||
def __init__(self, output: typing.IO):
|
def __init__(self, output: typing.IO[str]):
|
||||||
self._output = output
|
self._output = output
|
||||||
self._use_color = output.isatty()
|
self._use_color = output.isatty()
|
||||||
|
|
||||||
|
@ -37,7 +37,7 @@ def main(argv: Sequence[str]) -> None:
|
|||||||
if argv:
|
if argv:
|
||||||
raise RuntimeError('This script takes no arguments')
|
raise RuntimeError('This script takes no arguments')
|
||||||
|
|
||||||
future_to_name: Dict[futures.Future, str] = {}
|
future_to_name: Dict[futures.Future[None], str] = {}
|
||||||
executor = futures.ThreadPoolExecutor(max_workers=len(commands))
|
executor = futures.ThreadPoolExecutor(max_workers=len(commands))
|
||||||
for name, argv in commands.items():
|
for name, argv in commands.items():
|
||||||
if name in necessary_deps and shutil.which(necessary_deps[name]) is None:
|
if name in necessary_deps and shutil.which(necessary_deps[name]) is None:
|
||||||
|
Loading…
x
Reference in New Issue
Block a user