iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

devlink: Create a helper function for one parameter registration

Browse Source 
Create and use a helper function for one parameter registration.
Subsequent patch also will reuse this for driver facing routine to
register a single parameter.

Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Parav Pandit 2021-08-10 16:24:18 +03:00 committed by David S. Miller
parent 076b2a9dbb
commit 699784f7b7
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
net/core/devlink.c
View File

@ -9800,6 +9800,22 @@ static int devlink_param_verify(const struct devlink_param *param)
return devlink_param_driver_verify(param); return devlink_param_driver_verify(param);
} }
static int __devlink_param_register_one(struct devlink *devlink,
unsigned int port_index,
struct list_head *param_list,
const struct devlink_param *param,
enum devlink_command reg_cmd)
{
int err;
err = devlink_param_verify(param);
if (err)
return err;
return devlink_param_register_one(devlink, port_index,
param_list, param, reg_cmd);
}
static int __devlink_params_register(struct devlink *devlink, static int __devlink_params_register(struct devlink *devlink,
unsigned int port_index, unsigned int port_index,
struct list_head *param_list, struct list_head *param_list,
@ -9814,12 +9830,8 @@ static int __devlink_params_register(struct devlink *devlink,
mutex_lock(&devlink->lock); mutex_lock(&devlink->lock);
for (i = 0; i < params_count; i++, param++) { for (i = 0; i < params_count; i++, param++) {
err = devlink_param_verify(param); err = __devlink_param_register_one(devlink, port_index,
if (err) param_list, param, reg_cmd);
goto rollback;
err = devlink_param_register_one(devlink, port_index,
param_list, param, reg_cmd);
if (err) if (err)
goto rollback; goto rollback;
} }