iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ip_vs.h: fix implicit use of module_get/module_put from module.h

Browse Source 
This file was using the module get/put functions in two simple inline
functions.  But module_get/put were only within scope because of
the implicit presence of module.h being everywhere.

Rather than add module.h to another file in include/  -- which is
exactly the thing we are trying to avoid, simply convert these
one-line functions into a define, as per what was done for the
device_schedule_callback() in commit 523ded71de.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
This commit is contained in:
Paul Gortmaker 2011-08-29 12:40:15 -04:00
parent 34641c6d00
commit 69e7dae409
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
include/net/ip_vs.h
View File

@ -1126,17 +1126,16 @@ int unregister_ip_vs_pe(struct ip_vs_pe *pe);
struct ip_vs_pe *ip_vs_pe_getbyname(const char *name); struct ip_vs_pe *ip_vs_pe_getbyname(const char *name);
struct ip_vs_pe *__ip_vs_pe_getbyname(const char *pe_name); struct ip_vs_pe *__ip_vs_pe_getbyname(const char *pe_name);
static inline void ip_vs_pe_get(const struct ip_vs_pe *pe) /*
{ * Use a #define to avoid all of module.h just for these trivial ops
if (pe && pe->module) */
#define ip_vs_pe_get(pe) \
if (pe && pe->module) \
__module_get(pe->module); __module_get(pe->module);
}
static inline void ip_vs_pe_put(const struct ip_vs_pe *pe) #define ip_vs_pe_put(pe) \
{ if (pe && pe->module) \
if (pe && pe->module)
module_put(pe->module); module_put(pe->module);
}
/* /*
* IPVS protocol functions (from ip_vs_proto.c) * IPVS protocol functions (from ip_vs_proto.c)