iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ACPI: HMAT: Release platform device in case of platform_device_add_data() fails

Browse Source 
The platform device is not released when platform_device_add_data()
fails. And platform_device_put() perfom one more pointer check than
put_device() to check for errors in the 'pdev' pointer.

Use platform_device_put() to release platform device in
platform_device_add()/platform_device_add_data()/
platform_device_add_resources() error case.

Fixes: c01044cc8191 ("ACPI: HMAT: refactor hmat_register_target_device to hmem_register_device")
Signed-off-by: Lin Yujun <linyujun809@huawei.com>
Link: https://lore.kernel.org/r/20220914033755.99924-1-linyujun809@huawei.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Lin Yujun 2022-09-14 11:37:55 +08:00 committed by Dan Williams
parent 0f702033a6
commit 6a02124c87
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/dax/hmem/device.c
View File

@ -47,7 +47,7 @@ void hmem_register_device(int target_nid, struct resource *r)
rc = platform_device_add_data(pdev, &info, sizeof(info));
if (rc < 0) {
pr_err("hmem memregion_info allocation failure for %pr\n", &res);
goto out_pdev;
goto out_resource;
}
rc = platform_device_add_resources(pdev, &res, 1);
@ -65,7 +65,7 @@ void hmem_register_device(int target_nid, struct resource *r)
return;
out_resource:
put_device(&pdev->dev);
platform_device_put(pdev);
out_pdev:
memregion_free(id);
}