iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crypto: tcrypt - Fix leak of struct aead_request in test_aead_speed()

Browse Source 
Fix leakage of memory for struct aead_request that is allocated via
aead_request_alloc() but not released via aead_request_free().
Reported by Coverity - CID 1163869.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Reviewed-by: Marek Vasut <marex@denx.de>
Acked-by: Tim Chen <tim.c.chen@linux.intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Christian Engelmayer 2014-04-21 20:47:05 +02:00 committed by Herbert Xu
parent a2ea6ed6a6
commit 6af1f93e2a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crypto/tcrypt.c
View File

@ -320,7 +320,7 @@ static void test_aead_speed(const char *algo, int enc, unsigned int sec,
if (!req) { if (!req) {
pr_err("alg: aead: Failed to allocate request for %s\n", pr_err("alg: aead: Failed to allocate request for %s\n",
algo); algo);
goto out; goto out_noreq;
} }
i = 0; i = 0;
@ -390,6 +390,8 @@ static void test_aead_speed(const char *algo, int enc, unsigned int sec,
} while (*keysize); } while (*keysize);
out: out:
aead_request_free(req);
out_noreq:
crypto_free_aead(tfm); crypto_free_aead(tfm);
out_notfm: out_notfm:
kfree(sg); kfree(sg);