iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crypto: af_alg - Decrement struct key.usage in alg_set_by_key_serial()

Browse Source 
Calls to lookup_user_key() require a corresponding key_put() to
decrement the usage counter. Once it reaches zero, we schedule key GC.
Therefore decrement struct key.usage in alg_set_by_key_serial().

Fixes: 7984ceb134bf ("crypto: af_alg - Support symmetric encryption via keyring keys")
Cc: <stable@vger.kernel.org>
Signed-off-by: Frederick Lawler <fred@cloudflare.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Frederick Lawler 2023-08-01 08:57:09 -05:00 committed by Herbert Xu
parent ac2d838fb7
commit 6b4b53ca0b
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
crypto/af_alg.c
View File

@ -320,18 +320,21 @@ static int alg_setkey_by_key_serial(struct alg_sock *ask, sockptr_t optval,
if (IS_ERR(ret)) { if (IS_ERR(ret)) {
up_read(&key->sem); up_read(&key->sem);
key_put(key);
return PTR_ERR(ret); return PTR_ERR(ret);
} }
key_data = sock_kmalloc(&ask->sk, key_datalen, GFP_KERNEL); key_data = sock_kmalloc(&ask->sk, key_datalen, GFP_KERNEL);
if (!key_data) { if (!key_data) {
up_read(&key->sem); up_read(&key->sem);
key_put(key);
return -ENOMEM; return -ENOMEM;
} }
memcpy(key_data, ret, key_datalen); memcpy(key_data, ret, key_datalen);
up_read(&key->sem); up_read(&key->sem);
key_put(key);
err = type->setkey(ask->private, key_data, key_datalen); err = type->setkey(ask->private, key_data, key_datalen);