iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/bridge: anx7625: disable regulators when power off

Browse Source 
When suspending the driver, anx7625_power_standby() will be called to
turn off reset-gpios and enable-gpios. However, power supplies are not
disabled. To save power, the driver can get the power supply regulators
and turn off them in anx7625_power_standby().

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Reviewed-by: Xin Ji <xji@analogixsemi.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210401053202.159302-2-hsinyi@chromium.org
This commit is contained in:
Hsin-Yi Wang 2021-04-01 13:32:02 +08:00 committed by Robert Foss
parent 2f240cdb23
commit 6c74498300
No known key found for this signature in database
GPG Key ID: 3EFD900F76D1D784
2 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
drivers/gpu/drm/bridge/analogix/anx7625.c
View File

@ -11,6 +11,7 @@
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/mutex.h> #include <linux/mutex.h>
#include <linux/regulator/consumer.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/types.h> #include <linux/types.h>
#include <linux/workqueue.h> #include <linux/workqueue.h>
@ -875,12 +876,25 @@ static int sp_tx_edid_read(struct anx7625_data *ctx,
static void anx7625_power_on(struct anx7625_data *ctx) static void anx7625_power_on(struct anx7625_data *ctx)
{ {
struct device *dev = &ctx->client->dev; struct device *dev = &ctx->client->dev;
int ret, i;
if (!ctx->pdata.low_power_mode) { if (!ctx->pdata.low_power_mode) {
DRM_DEV_DEBUG_DRIVER(dev, "not low power mode!\n"); DRM_DEV_DEBUG_DRIVER(dev, "not low power mode!\n");
return; return;
} }
for (i = 0; i < ARRAY_SIZE(ctx->pdata.supplies); i++) {
ret = regulator_enable(ctx->pdata.supplies[i].consumer);
if (ret < 0) {
DRM_DEV_DEBUG_DRIVER(dev, "cannot enable supply %d: %d\n",
i, ret);
goto reg_err;
}
usleep_range(2000, 2100);
}
usleep_range(4000, 4100);
/* Power on pin enable */ /* Power on pin enable */
gpiod_set_value(ctx->pdata.gpio_p_on, 1); gpiod_set_value(ctx->pdata.gpio_p_on, 1);
usleep_range(10000, 11000); usleep_range(10000, 11000);
@ -889,11 +903,16 @@ static void anx7625_power_on(struct anx7625_data *ctx)
usleep_range(10000, 11000); usleep_range(10000, 11000);
DRM_DEV_DEBUG_DRIVER(dev, "power on !\n"); DRM_DEV_DEBUG_DRIVER(dev, "power on !\n");
return;
reg_err:
for (--i; i >= 0; i--)
regulator_disable(ctx->pdata.supplies[i].consumer);
} }
static void anx7625_power_standby(struct anx7625_data *ctx) static void anx7625_power_standby(struct anx7625_data *ctx)
{ {
struct device *dev = &ctx->client->dev; struct device *dev = &ctx->client->dev;
int ret;
if (!ctx->pdata.low_power_mode) { if (!ctx->pdata.low_power_mode) {
DRM_DEV_DEBUG_DRIVER(dev, "not low power mode!\n"); DRM_DEV_DEBUG_DRIVER(dev, "not low power mode!\n");
@ -904,6 +923,12 @@ static void anx7625_power_standby(struct anx7625_data *ctx)
usleep_range(1000, 1100); usleep_range(1000, 1100);
gpiod_set_value(ctx->pdata.gpio_p_on, 0); gpiod_set_value(ctx->pdata.gpio_p_on, 0);
usleep_range(1000, 1100); usleep_range(1000, 1100);
ret = regulator_bulk_disable(ARRAY_SIZE(ctx->pdata.supplies),
ctx->pdata.supplies);
if (ret < 0)
DRM_DEV_DEBUG_DRIVER(dev, "cannot disable supplies %d\n", ret);
DRM_DEV_DEBUG_DRIVER(dev, "power down\n"); DRM_DEV_DEBUG_DRIVER(dev, "power down\n");
} }
@ -1742,6 +1767,15 @@ static int anx7625_i2c_probe(struct i2c_client *client,
platform->client = client; platform->client = client;
i2c_set_clientdata(client, platform); i2c_set_clientdata(client, platform);
pdata->supplies[0].supply = "vdd10";
pdata->supplies[1].supply = "vdd18";
pdata->supplies[2].supply = "vdd33";
ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(pdata->supplies),
pdata->supplies);
if (ret) {
DRM_DEV_ERROR(dev, "fail to get power supplies: %d\n", ret);
return ret;
}
anx7625_init_gpio(platform); anx7625_init_gpio(platform);
atomic_set(&platform->power_status, 0); atomic_set(&platform->power_status, 0);

1
drivers/gpu/drm/bridge/analogix/anx7625.h
View File

@ -350,6 +350,7 @@ struct s_edid_data {
struct anx7625_platform_data { struct anx7625_platform_data {
struct gpio_desc *gpio_p_on; struct gpio_desc *gpio_p_on;
struct gpio_desc *gpio_reset; struct gpio_desc *gpio_reset;
struct regulator_bulk_data supplies[3];
struct drm_bridge *panel_bridge; struct drm_bridge *panel_bridge;
int intp_irq; int intp_irq;
u32 low_power_mode; u32 low_power_mode;