iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Input: pxa27x_keypad keep clock on as wakeup source

Browse Source 
When the keypad is used as wake up source, the clock can not
be disabled. Or it can not detect key pressing.
If the keypad is used as wake up source, when resume back,
do not enable the clock and configure it again because the
register content is retained.

Signed-off-by: Chao Xie <chao.xie@marvell.com>
Signed-off-by: Haojian Zhuang <haojian.zhuang@gmail.com>
This commit is contained in:
Chao Xie 2012-04-01 10:08:01 +08:00 committed by Haojian Zhuang
parent 66f75a5d02
commit 6ce34a5fb4
1 changed files with 21 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
drivers/input/keyboard/pxa27x_keypad.c
View File

@ -399,7 +399,7 @@ static int pxa27x_keypad_open(struct input_dev *dev)
struct pxa27x_keypad *keypad = input_get_drvdata(dev); struct pxa27x_keypad *keypad = input_get_drvdata(dev);
/* Enable unit clock */ /* Enable unit clock */
clk_enable(keypad->clk); clk_prepare_enable(keypad->clk);
pxa27x_keypad_config(keypad); pxa27x_keypad_config(keypad);
return 0; return 0;
@ -410,7 +410,7 @@ static void pxa27x_keypad_close(struct input_dev *dev)
struct pxa27x_keypad *keypad = input_get_drvdata(dev); struct pxa27x_keypad *keypad = input_get_drvdata(dev);
/* Disable clock unit */ /* Disable clock unit */
clk_disable(keypad->clk); clk_disable_unprepare(keypad->clk);
} }
#ifdef CONFIG_PM #ifdef CONFIG_PM
@ -419,10 +419,14 @@ static int pxa27x_keypad_suspend(struct device *dev)
struct platform_device *pdev = to_platform_device(dev); struct platform_device *pdev = to_platform_device(dev);
struct pxa27x_keypad *keypad = platform_get_drvdata(pdev); struct pxa27x_keypad *keypad = platform_get_drvdata(pdev);
clk_disable(keypad->clk); /*
* If the keypad is used a wake up source, clock can not be disabled.
* Or it can not detect the key pressing.
*/
if (device_may_wakeup(&pdev->dev)) if (device_may_wakeup(&pdev->dev))
enable_irq_wake(keypad->irq); enable_irq_wake(keypad->irq);
else
clk_disable_unprepare(keypad->clk);
return 0; return 0;
} }
@ -433,19 +437,24 @@ static int pxa27x_keypad_resume(struct device *dev)
struct pxa27x_keypad *keypad = platform_get_drvdata(pdev); struct pxa27x_keypad *keypad = platform_get_drvdata(pdev);
struct input_dev *input_dev = keypad->input_dev; struct input_dev *input_dev = keypad->input_dev;
if (device_may_wakeup(&pdev->dev)) /*
* If the keypad is used as wake up source, the clock is not turned
* off. So do not need configure it again.
*/
if (device_may_wakeup(&pdev->dev)) {
disable_irq_wake(keypad->irq); disable_irq_wake(keypad->irq);
} else {
mutex_lock(&input_dev->mutex);
mutex_lock(&input_dev->mutex); if (input_dev->users) {
/* Enable unit clock */
clk_prepare_enable(keypad->clk);
pxa27x_keypad_config(keypad);
}
if (input_dev->users) { mutex_unlock(&input_dev->mutex);
/* Enable unit clock */
clk_enable(keypad->clk);
pxa27x_keypad_config(keypad);
} }
mutex_unlock(&input_dev->mutex);
return 0; return 0;
} }