iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: svc: Print expected/actual payload size on mismatch

Browse Source 
Print (expected-payload-size actual-payload-size), when the size doesn't
match for requests received by the module. This gives more details
required for debugging the issue.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Viresh Kumar 2015-08-06 12:44:54 +05:30 committed by Greg Kroah-Hartman
parent 76ecf73ee4
commit 6d05ad3c42
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/greybus/svc.c
View File

@ -269,7 +269,8 @@ static int gb_svc_intf_hotplug_recv(struct gb_operation *op)
int ret;
if (request->payload_size < sizeof(*hotplug)) {
dev_err(dev, "%s: short hotplug request received\n", __func__);
dev_err(dev, "%s: short hotplug request received (%zu < %zu)\n",
__func__, request->payload_size, sizeof(*hotplug));
return -EINVAL;
}
@ -372,7 +373,8 @@ static int gb_svc_intf_hot_unplug_recv(struct gb_operation *op)
if (request->payload_size < sizeof(*hot_unplug)) {
dev_err(&op->connection->dev,
"short hot unplug request received\n");
"short hot unplug request received (%zu < %zu)\n",
request->payload_size, sizeof(*hot_unplug));
return -EINVAL;
}
@ -400,7 +402,8 @@ static int gb_svc_intf_reset_recv(struct gb_operation *op)
if (request->payload_size < sizeof(*reset)) {
dev_err(&op->connection->dev,
"short reset request received\n");
"short reset request received (%zu < %zu)\n",
request->payload_size, sizeof(*reset));
return -EINVAL;
}
reset = request->payload;