iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

leds: lp50xx: Fix an error handling path in 'lp50xx_probe_dt()'

Browse Source 
In case of memory allocation failure, we must release some resources as
done in all other error handling paths of the function.

'goto child_out' instead of a direct return so that 'fwnode_handle_put()'
is called when we break out of a 'device_for_each_child_node' loop.

Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
This commit is contained in:
Christophe JAILLET 2020-09-22 23:05:15 +02:00 committed by Pavel Machek
parent 311066aa9e
commit 6d8d014c7d
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/leds/leds-lp50xx.c
View File

@ -487,8 +487,10 @@ static int lp50xx_probe_dt(struct lp50xx *priv)
*/ */
mc_led_info = devm_kcalloc(priv->dev, LP50XX_LEDS_PER_MODULE, mc_led_info = devm_kcalloc(priv->dev, LP50XX_LEDS_PER_MODULE,
sizeof(*mc_led_info), GFP_KERNEL); sizeof(*mc_led_info), GFP_KERNEL);
if (!mc_led_info) if (!mc_led_info) {
return -ENOMEM; ret = -ENOMEM;
goto child_out;
}
fwnode_for_each_child_node(child, led_node) { fwnode_for_each_child_node(child, led_node) {
ret = fwnode_property_read_u32(led_node, "color", ret = fwnode_property_read_u32(led_node, "color",