iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fbmem: fix horribly incorrect placement of __maybe_unused

Browse Source 
Commit b9d79e4ca4ff ("fbmem: Mark proc_fb_seq_ops as __maybe_unused")
places the '__maybe_unused' in an entirely incorrect location between
the "struct" keyword and the structure name.

It's a wonder that gcc accepts that silently, but clang quite reasonably
warns about it:

    drivers/video/fbdev/core/fbmem.c:736:21: warning: attribute declaration must precede definition [-Wignored-attributes]
    static const struct __maybe_unused seq_operations proc_fb_seq_ops = {
                        ^

Fix it.

Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Linus Torvalds 2021-05-09 14:03:33 -07:00
parent efc58a96ad
commit 6dae40aed4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/video/fbdev/core/fbmem.c
View File

@ -733,7 +733,7 @@ static int fb_seq_show(struct seq_file *m, void *v)
return 0; return 0;
} }
static const struct __maybe_unused seq_operations proc_fb_seq_ops = { static const struct seq_operations __maybe_unused proc_fb_seq_ops = {
.start = fb_seq_start, .start = fb_seq_start,
.next = fb_seq_next, .next = fb_seq_next,
.stop = fb_seq_stop, .stop = fb_seq_stop,