iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: lustre: llite: set security xattr using __vfs_setxattr

Browse Source 
Currently ll_initxattrs() initializes the security xattrs in
a very non-standard using get_xattr_types() to get the struct
handler that lustre created to then call indirectly the function
to set the xattr. The available __vfs_setxattr() function does
the same thing and also handles the case of when size is zero
the xattr should be set to empty EA.

Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183
Reviewed-on: https://review.whamcloud.com/27240
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Sebastien Buisson <sbuisson@ddn.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
James Simmons 2017-07-26 11:22:36 -04:00 committed by Greg Kroah-Hartman
parent a49c8634a9
commit 6e3ff3c2b3
1 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/staging/lustre/lustre/llite/xattr_security.c
View File

@ -28,7 +28,10 @@
* lustre/llite/xattr_security.c
* Handler for storing security labels as extended attributes.
*/
#include <linux/types.h>
#include <linux/security.h>
#include <linux/selinux.h>
#include <linux/xattr.h>
#include "llite_internal.h"
@ -48,19 +51,23 @@ static int
ll_initxattrs(struct inode *inode, const struct xattr *xattr_array,
void *fs_info)
{
const struct xattr_handler *handler;
struct dentry *dentry = fs_info;
const struct xattr *xattr;
int err = 0;
handler = get_xattr_type(XATTR_SECURITY_PREFIX);
if (!handler)
return -ENXIO;
for (xattr = xattr_array; xattr->name; xattr++) {
err = handler->set(handler, dentry, inode, xattr->name,
xattr->value, xattr->value_len,
XATTR_CREATE);
char *full_name;
full_name = kasprintf(GFP_KERNEL, "%s%s",
XATTR_SECURITY_PREFIX, xattr->name);
if (!full_name) {
err = -ENOMEM;
break;
}
err = __vfs_setxattr(dentry, inode, full_name, xattr->value,
xattr->value_len, XATTR_CREATE);
kfree(full_name);
if (err < 0)
break;
}