iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Btrfs: fix kfree on list_head in btrfs_lookup_csums_range error cleanup

Browse Source 
If we hit any errors in btrfs_lookup_csums_range, we'll loop through all
the csums we allocate and free them.  But the code was using list_entry
incorrectly, and ended up trying to free the on-stack list_head instead.

This bug came from commit 0678b6185

btrfs: Don't BUG_ON kzalloc error in btrfs_lookup_csums_range()

Signed-off-by: Chris Mason <clm@fb.com>
Reported-by: Erik Berg <btrfs@slipsprogrammoer.no>
cc: stable@vger.kernel.org # 3.3 or newer
This commit is contained in:
Chris Mason 2014-11-04 06:59:04 -08:00
parent d05a2b4cd9
commit 6e5aafb274
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/btrfs/file-item.c
View File

@ -413,7 +413,7 @@ int btrfs_lookup_csums_range(struct btrfs_root *root, u64 start, u64 end,
ret = 0; ret = 0;
fail: fail:
while (ret < 0 && !list_empty(&tmplist)) { while (ret < 0 && !list_empty(&tmplist)) {
sums = list_entry(&tmplist, struct btrfs_ordered_sum, list); sums = list_entry(tmplist.next, struct btrfs_ordered_sum, list);
list_del(&sums->list); list_del(&sums->list);
kfree(sums); kfree(sums);
} }