iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PATCH] powerpc: tidy-up of_register_driver()/driver_register() return values

Browse Source 
Remove the assumption that driver_register() returns the number of devices
bound to the driver.  In fact, it returns zero for success or a negative
error value.

Nobody uses the return value of of_register_driver() anyway.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Bjorn Helgaas 2006-03-21 23:20:27 -08:00 committed by Paul Mackerras
parent 57ae595f6b
commit 6ea671a12f
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
arch/powerpc/kernel/of_device.c
View File

@ -147,15 +147,12 @@ postcore_initcall(of_bus_driver_init);
int of_register_driver(struct of_platform_driver *drv) int of_register_driver(struct of_platform_driver *drv)
{ {
int count = 0;
/* initialize common driver fields */ /* initialize common driver fields */
drv->driver.name = drv->name; drv->driver.name = drv->name;
drv->driver.bus = &of_platform_bus_type; drv->driver.bus = &of_platform_bus_type;
/* register with core */ /* register with core */
count = driver_register(&drv->driver); return driver_register(&drv->driver);
return count ? count : 1;
} }
void of_unregister_driver(struct of_platform_driver *drv) void of_unregister_driver(struct of_platform_driver *drv)

4
drivers/macintosh/smu.c
View File

@ -629,8 +629,6 @@ static struct of_platform_driver smu_of_platform_driver =
static int __init smu_init_sysfs(void) static int __init smu_init_sysfs(void)
{ {
int rc;
/* /*
* Due to sysfs bogosity, a sysdev is not a real device, so * Due to sysfs bogosity, a sysdev is not a real device, so
* we should in fact create both if we want sysdev semantics * we should in fact create both if we want sysdev semantics
@ -639,7 +637,7 @@ static int __init smu_init_sysfs(void)
* I'm a bit too far from figuring out how that works with those * I'm a bit too far from figuring out how that works with those
* new chipsets, but that will come back and bite us * new chipsets, but that will come back and bite us
*/ */
rc = of_register_driver(&smu_of_platform_driver); of_register_driver(&smu_of_platform_driver);
return 0; return 0;
} }