iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: loopback: add more clean up when init connection fails

Browse Source 
It should remove the object from sysfs when loopback
connection init error.

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Phong Tran 2015-05-14 23:03:04 +07:00 committed by Greg Kroah-Hartman
parent 65cac604b2
commit 6f8528e0be
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/staging/greybus/loopback.c
View File

@ -401,23 +401,25 @@ static int gb_loopback_connection_init(struct gb_connection *connection)
connection->private = gb;
retval = sysfs_create_groups(&connection->dev.kobj, loopback_groups);
if (retval)
goto error;
goto out_free;
/* Check the version */
retval = get_version(gb);
if (retval)
goto error;
goto out_get_ver;
gb_loopback_reset_stats(gb);
gb->task = kthread_run(gb_loopback_fn, gb, "gb_loopback");
if (IS_ERR(gb->task)) {
retval = PTR_ERR(gb->task);
goto error;
goto out_get_ver;
}
return 0;
error:
out_get_ver:
sysfs_remove_groups(&connection->dev.kobj, loopback_groups);
out_free:
kfree(gb);
return retval;
}