iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

printk: drop redundant devkmsg_log_str memsets

Browse Source 
We copy in null terminated strings "on" and "off", no
need to zero out devkmsg_log_str in control_devkmsg().

Link: http://lkml.kernel.org/r/20180119043901.1728-1-sergey.senozhatsky@gmail.com
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Petr Mladek <pmladek@suse.com>
This commit is contained in:
Sergey Senozhatsky 2018-01-19 13:39:01 +09:00 committed by Petr Mladek
parent cca10d58d2
commit 6fd78a1a99
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
kernel/printk/printk.c
View File

@ -131,13 +131,10 @@ static int __init control_devkmsg(char *str)
/* /*
* Set sysctl string accordingly: * Set sysctl string accordingly:
*/ */
if (devkmsg_log == DEVKMSG_LOG_MASK_ON) { if (devkmsg_log == DEVKMSG_LOG_MASK_ON)
memset(devkmsg_log_str, 0, DEVKMSG_STR_MAX_SIZE); strcpy(devkmsg_log_str, "on");
strncpy(devkmsg_log_str, "on", 2); else if (devkmsg_log == DEVKMSG_LOG_MASK_OFF)
} else if (devkmsg_log == DEVKMSG_LOG_MASK_OFF) { strcpy(devkmsg_log_str, "off");
memset(devkmsg_log_str, 0, DEVKMSG_STR_MAX_SIZE);
strncpy(devkmsg_log_str, "off", 3);
}
/* else "ratelimit" which is set by default. */ /* else "ratelimit" which is set by default. */
/* /*