iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

spi/s3c64xx: Put the /CS GPIO into output mode

Browse Source 
No call was being made by the GPIO driver to put the GPIO into output
mode meaning that the calls to gpio_set_value() which were being done
were not valid. A similar issue appears to exist with the DT GPIO
requests but as they appear to be being used for pinmux it's less clear
to me that we want to configure them.

Without this fix Cragganmore systems can't talk to their SPI devices.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
This commit is contained in:
Mark Brown 2012-07-19 14:36:16 +09:00 committed by Kukjin Kim
parent 49f3eacfcd
commit 707214d097
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/spi/spi-s3c64xx.c
View File

@ -894,7 +894,8 @@ static int s3c64xx_spi_setup(struct spi_device *spi)
} }
if (!spi_get_ctldata(spi)) { if (!spi_get_ctldata(spi)) {
err = gpio_request(cs->line, dev_name(&spi->dev)); err = gpio_request_one(cs->line, GPIOF_OUT_INIT_HIGH,
dev_name(&spi->dev));
if (err) { if (err) {
dev_err(&spi->dev, dev_err(&spi->dev,
"Failed to get /CS gpio [%d]: %d\n", "Failed to get /CS gpio [%d]: %d\n",