iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xfs: calculate correct offset in xfs_scrub_quota_item

Browse Source 
It's only used for tracepoints so it's relatively harmless,
but the offset is calculated incorrectly in xfs_scrub_quota_item.

qi_dqperchunk is the nr. of dquots per "chunk" which we have
conveniently *cough* defined to always be 1 FSB.  Therefore
block_offset * qi_dqperchunk == first id in that chunk,
and so offset = id / qi_dqperchunk

id * dqperchunk is ... meaningless.

Fixes-coverity-id: 1423965
Fixes: c2fc338c ("xfs: scrub quota information")
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
This commit is contained in:
Eric Sandeen 2017-11-27 18:23:33 -08:00 committed by Darrick J. Wong
parent eda6bc27cc
commit 712d361d59
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/xfs/scrub/quota.c
View File

@ -107,7 +107,7 @@ xfs_scrub_quota_item(
unsigned long long rcount; unsigned long long rcount;
xfs_ino_t fs_icount; xfs_ino_t fs_icount;
offset = id * qi->qi_dqperchunk; offset = id / qi->qi_dqperchunk;
/* /*
* We fed $id and DQNEXT into the xfs_qm_dqget call, which means * We fed $id and DQNEXT into the xfs_qm_dqget call, which means