iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: interface: put module->dev on failures

Browse Source 
In order to decrement the reference count of module on failures, we must call
put_device(module->dev). This was missing for one of the error cases, fix it.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Viresh Kumar 2015-03-24 20:14:29 +05:30 committed by Greg Kroah-Hartman
parent 0d34be7587
commit 71e4938012
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/staging/greybus/interface.c
View File

@ -132,7 +132,7 @@ static struct gb_interface *gb_interface_create(struct greybus_host_device *hd,
intf = kzalloc(sizeof(*intf), GFP_KERNEL);
if (!intf)
return NULL;
goto put_module;
intf->hd = hd; /* XXX refcount? */
intf->module = module;
@ -151,10 +151,7 @@ static struct gb_interface *gb_interface_create(struct greybus_host_device *hd,
if (retval) {
pr_err("failed to add module device for id 0x%02hhx\n",
module_id);
put_device(&intf->dev);
put_device(&module->dev);
kfree(intf);
return NULL;
goto free_intf;
}
spin_lock_irq(&gb_interfaces_lock);
@ -162,6 +159,13 @@ static struct gb_interface *gb_interface_create(struct greybus_host_device *hd,
spin_unlock_irq(&gb_interfaces_lock);
return intf;
free_intf:
put_device(&intf->dev);
kfree(intf);
put_module:
put_device(&module->dev);
return NULL;
}
/*