iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RDS: Do not BUG() on error returned from ib_post_send

Browse Source 
BUGging on a runtime error code should be avoided. This
patch also eliminates all other BUG()s that have no real
reason to exist.

Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Andy Grover 2010-03-11 13:49:55 +00:00 committed by David S. Miller
parent 87faf3ccf1
commit 735f61e626
5 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/rds/ib_recv.c
View File

@ -468,8 +468,8 @@ static void rds_ib_send_ack(struct rds_ib_connection *ic, unsigned int adv_credi
set_bit(IB_ACK_REQUESTED, &ic->i_ack_flags);
rds_ib_stats_inc(s_ib_ack_send_failure);
/* Need to finesse this later. */
BUG();
rds_ib_conn_error(ic->conn, "sending ack failed\n");
} else
rds_ib_stats_inc(s_ib_ack_sent);
}

7
net/rds/ib_send.c
View File

@ -574,8 +574,7 @@ int rds_ib_xmit(struct rds_connection *conn, struct rds_message *rm,
rds_ib_send_grab_credits(ic, 0, &posted, 1, RDS_MAX_ADV_CREDIT - adv_credits);
adv_credits += posted;
BUG_ON(adv_credits > 255);
} else if (ic->i_rm != rm)
BUG();
}
send = &ic->i_sends[pos];
first = send;
@ -714,8 +713,8 @@ add_header:
ic->i_rm = prev->s_rm;
prev->s_rm = NULL;
}
/* Finesse this later */
BUG();
rds_ib_conn_error(ic->conn, "ib_post_send failed\n");
goto out;
}

4
net/rds/iw_recv.c
View File

@ -468,8 +468,8 @@ static void rds_iw_send_ack(struct rds_iw_connection *ic, unsigned int adv_credi
set_bit(IB_ACK_REQUESTED, &ic->i_ack_flags);
rds_iw_stats_inc(s_iw_ack_send_failure);
/* Need to finesse this later. */
BUG();
rds_iw_conn_error(ic->conn, "sending ack failed\n");
} else
rds_iw_stats_inc(s_iw_ack_sent);
}

3
net/rds/iw_send.c
View File

@ -616,8 +616,7 @@ int rds_iw_xmit(struct rds_connection *conn, struct rds_message *rm,
rds_iw_send_grab_credits(ic, 0, &posted, 1, RDS_MAX_ADV_CREDIT - adv_credits);
adv_credits += posted;
BUG_ON(adv_credits > 255);
} else if (ic->i_rm != rm)
BUG();
}
send = &ic->i_sends[pos];
first = send;

3
net/rds/rdma_transport.c
View File

@ -109,8 +109,7 @@ int rds_rdma_cm_event_handler(struct rdma_cm_id *cm_id,
default:
/* things like device disconnect? */
printk(KERN_ERR "unknown event %u\n", event->event);
BUG();
printk(KERN_ERR "RDS: unknown event %u!\n", event->event);
break;
}