platform/goldfish: goldfish_pipe: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20231112000029.151117-2-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
bc1183a630
commit
736dfbde3a
@ -915,12 +915,11 @@ static int goldfish_pipe_probe(struct platform_device *pdev)
|
||||
return goldfish_pipe_device_init(pdev, dev);
|
||||
}
|
||||
|
||||
static int goldfish_pipe_remove(struct platform_device *pdev)
|
||||
static void goldfish_pipe_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct goldfish_pipe_dev *dev = platform_get_drvdata(pdev);
|
||||
|
||||
goldfish_pipe_device_deinit(pdev, dev);
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct acpi_device_id goldfish_pipe_acpi_match[] = {
|
||||
@ -937,7 +936,7 @@ MODULE_DEVICE_TABLE(of, goldfish_pipe_of_match);
|
||||
|
||||
static struct platform_driver goldfish_pipe_driver = {
|
||||
.probe = goldfish_pipe_probe,
|
||||
.remove = goldfish_pipe_remove,
|
||||
.remove_new = goldfish_pipe_remove,
|
||||
.driver = {
|
||||
.name = "goldfish_pipe",
|
||||
.of_match_table = goldfish_pipe_of_match,
|
||||
|
Loading…
Reference in New Issue
Block a user