iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iio: dac: adi-axi: fix a mistake in axi_dac_ext_info_set()

Browse Source 
The last parameter of these axi_dac_(frequency|scale|phase)_set()
functions is supposed to be true for TONE_2 and false for TONE_1. The
bug is the last call where it passes "private - TONE_2".  That
subtraction is going to be zero/false for TONE_2 and and -1/true for
TONE_1.  Fix the bug, and re-write it as "private == TONE_2" so it's
more obvious what is happening.

Fixes: 4e3949a192 ("iio: dac: add support for AXI DAC IP core")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/df7c6e1b-b619-40c3-9881-838587ed15d4@moroto.mountain
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Dan Carpenter 2024-04-24 14:45:30 +03:00 committed by Jonathan Cameron
parent a1432b5b4f
commit 73e49886a2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/iio/dac/adi-axi-dac.c
View File

@ -383,15 +383,15 @@ static int axi_dac_ext_info_set(struct iio_backend *back, uintptr_t private,
case AXI_DAC_FREQ_TONE_1: case AXI_DAC_FREQ_TONE_1:
case AXI_DAC_FREQ_TONE_2: case AXI_DAC_FREQ_TONE_2:
return axi_dac_frequency_set(st, chan, buf, len, return axi_dac_frequency_set(st, chan, buf, len,
private - AXI_DAC_FREQ_TONE_1); private == AXI_DAC_FREQ_TONE_2);
case AXI_DAC_SCALE_TONE_1: case AXI_DAC_SCALE_TONE_1:
case AXI_DAC_SCALE_TONE_2: case AXI_DAC_SCALE_TONE_2:
return axi_dac_scale_set(st, chan, buf, len, return axi_dac_scale_set(st, chan, buf, len,
private - AXI_DAC_SCALE_TONE_1); private == AXI_DAC_SCALE_TONE_2);
case AXI_DAC_PHASE_TONE_1: case AXI_DAC_PHASE_TONE_1:
case AXI_DAC_PHASE_TONE_2: case AXI_DAC_PHASE_TONE_2:
return axi_dac_phase_set(st, chan, buf, len, return axi_dac_phase_set(st, chan, buf, len,
private - AXI_DAC_PHASE_TONE_2); private == AXI_DAC_PHASE_TONE_2);
default: default:
return -EOPNOTSUPP; return -EOPNOTSUPP;
} }