iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[media] av7110: don't allow negative volumes

Browse Source 
The issue here is that we there is a static checker warning because we
have a user controlled volume setting and we cap the upper bound but we
allow negative numbers.  Negative volumes don't make sense, so let's
make these variables unsigned.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Dan Carpenter 2015-11-10 20:22:49 -02:00 committed by Mauro Carvalho Chehab
parent 4623e59674
commit 75d63a40a5
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/media/pci/ttpci/av7110_av.c
View File

@ -280,9 +280,11 @@ int av7110_pes_play(void *dest, struct dvb_ringbuffer *buf, int dlen)
}
int av7110_set_volume(struct av7110 *av7110, int volleft, int volright)
int av7110_set_volume(struct av7110 *av7110, unsigned int volleft,
unsigned int volright)
{
int err, vol, val, balance = 0;
unsigned int vol, val, balance = 0;
int err;
dprintk(2, "av7110:%p, \n", av7110);

3
drivers/media/pci/ttpci/av7110_av.h
View File

@ -10,7 +10,8 @@ extern int av7110_record_cb(struct dvb_filter_pes2ts *p2t, u8 *buf, size_t len);
extern int av7110_pes_play(void *dest, struct dvb_ringbuffer *buf, int dlen);
extern int av7110_write_to_decoder(struct dvb_demux_feed *feed, const u8 *buf, size_t len);
extern int av7110_set_volume(struct av7110 *av7110, int volleft, int volright);
extern int av7110_set_volume(struct av7110 *av7110, unsigned int volleft,
unsigned int volright);
extern int av7110_av_stop(struct av7110 *av7110, int av);
extern int av7110_av_start_record(struct av7110 *av7110, int av,
struct dvb_demux_feed *dvbdmxfeed);