iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NFS: Fix the locking in nfs4_callback_getattr

Browse Source 
The delegation is protected by RCU now, so we need to replace the
nfsi->rwsem protection with an rcu protected section.

Reported-by: Fred Isaman <iisaman@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
Trond Myklebust 2010-08-04 09:29:52 -04:00
parent 0d8a374673
commit 761fe93cdf
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/nfs/callback_proc.c
View File

@ -37,8 +37,8 @@ __be32 nfs4_callback_getattr(struct cb_getattrargs *args, struct cb_getattrres *
if (inode == NULL) if (inode == NULL)
goto out_putclient; goto out_putclient;
nfsi = NFS_I(inode); nfsi = NFS_I(inode);
down_read(&nfsi->rwsem); rcu_read_lock();
delegation = nfsi->delegation; delegation = rcu_dereference(nfsi->delegation);
if (delegation == NULL || (delegation->type & FMODE_WRITE) == 0) if (delegation == NULL || (delegation->type & FMODE_WRITE) == 0)
goto out_iput; goto out_iput;
res->size = i_size_read(inode); res->size = i_size_read(inode);
@ -53,7 +53,7 @@ __be32 nfs4_callback_getattr(struct cb_getattrargs *args, struct cb_getattrres *
args->bitmap[1]; args->bitmap[1];
res->status = 0; res->status = 0;
out_iput: out_iput:
up_read(&nfsi->rwsem); rcu_read_unlock();
iput(inode); iput(inode);
out_putclient: out_putclient:
nfs_put_client(clp); nfs_put_client(clp);