iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

uio_hv_generic: Remove use of PAGE_SIZE

Browse Source 
Remove use of PAGE_SIZE for device ring buffer size calculation, as
there is no dependency on device ring buffer size for linux kernel's
PAGE_SIZE. Use the absolute value of 2 MB instead.

Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
Reviewed-by: Long Li <longli@microsoft.com>
Link: https://lore.kernel.org/r/1711788723-8593-8-git-send-email-ssengar@linux.microsoft.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Saurabh Sengar 2024-03-30 01:52:03 -07:00 committed by Greg Kroah-Hartman
parent ec314f61e4
commit 76457f9a11
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/uio/uio_hv_generic.c
View File

@ -36,7 +36,6 @@
#define DRIVER_AUTHOR "Stephen Hemminger <sthemmin at microsoft.com>" #define DRIVER_AUTHOR "Stephen Hemminger <sthemmin at microsoft.com>"
#define DRIVER_DESC "Generic UIO driver for VMBus devices" #define DRIVER_DESC "Generic UIO driver for VMBus devices"
#define HV_RING_SIZE 512 /* pages */
#define SEND_BUFFER_SIZE (16 * 1024 * 1024) #define SEND_BUFFER_SIZE (16 * 1024 * 1024)
#define RECV_BUFFER_SIZE (31 * 1024 * 1024) #define RECV_BUFFER_SIZE (31 * 1024 * 1024)
@ -146,7 +145,7 @@ static const struct bin_attribute ring_buffer_bin_attr = {
.name = "ring", .name = "ring",
.mode = 0600, .mode = 0600,
}, },
.size = 2 * HV_RING_SIZE * PAGE_SIZE, .size = 2 * SZ_2M,
.mmap = hv_uio_ring_mmap, .mmap = hv_uio_ring_mmap,
}; };
@ -156,7 +155,7 @@ hv_uio_new_channel(struct vmbus_channel *new_sc)
{ {
struct hv_device *hv_dev = new_sc->primary_channel->device_obj; struct hv_device *hv_dev = new_sc->primary_channel->device_obj;
struct device *device = &hv_dev->device; struct device *device = &hv_dev->device;
const size_t ring_bytes = HV_RING_SIZE * PAGE_SIZE; const size_t ring_bytes = SZ_2M;
int ret; int ret;
/* Create host communication ring */ /* Create host communication ring */
@ -244,7 +243,7 @@ hv_uio_probe(struct hv_device *dev,
size_t ring_size = hv_dev_ring_size(channel); size_t ring_size = hv_dev_ring_size(channel);
if (!ring_size) if (!ring_size)
ring_size = HV_RING_SIZE * PAGE_SIZE; ring_size = SZ_2M;
pdata = devm_kzalloc(&dev->device, sizeof(*pdata), GFP_KERNEL); pdata = devm_kzalloc(&dev->device, sizeof(*pdata), GFP_KERNEL);
if (!pdata) if (!pdata)