iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bridge: mdb: reduce the indentation level in br_mdb_fill_info

Browse Source 
Switch the port check and skip if it's null, this allows us to reduce one
indentation level.

Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Nikolay Aleksandrov 2016-02-16 12:46:53 +01:00 committed by David S. Miller
parent 6bbd9a05a1
commit 76cc173d48
1 changed files with 17 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
net/bridge/br_mdb.c
View File

@ -88,9 +88,11 @@ static int br_mdb_fill_info(struct sk_buff *skb, struct netlink_callback *cb,
for (pp = &mp->ports; for (pp = &mp->ports;
(p = rcu_dereference(*pp)) != NULL; (p = rcu_dereference(*pp)) != NULL;
pp = &p->next) { pp = &p->next) {
port = p->port;
if (port) {
struct br_mdb_entry e; struct br_mdb_entry e;
port = p->port;
if (!port)
continue;
memset(&e, 0, sizeof(e)); memset(&e, 0, sizeof(e));
e.ifindex = port->dev->ifindex; e.ifindex = port->dev->ifindex;
e.vid = p->addr.vid; e.vid = p->addr.vid;
@ -108,7 +110,6 @@ static int br_mdb_fill_info(struct sk_buff *skb, struct netlink_callback *cb,
goto out; goto out;
} }
} }
}
nla_nest_end(skb, nest2); nla_nest_end(skb, nest2);
skip: skip:
idx++; idx++;