iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

memory: pl353: Fix error return code in pl353_smc_probe()

Browse Source 
When no child nodes are matched, an appropriate error code -ENODEV should
be returned. However, we currently do not explicitly assign this error
code to 'err'. As a result, 0 was incorrectly returned.

Fixes: fee10bd226 ("memory: pl353: Add driver for arm pl353 static memory controller")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210515040004.6983-1-thunder.leizhen@huawei.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
This commit is contained in:
Zhen Lei 2021-05-15 12:00:04 +08:00 committed by Krzysztof Kozlowski
parent 907c5bbb51
commit 76e5624f3f
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/memory/pl353-smc.c
View File

@ -407,6 +407,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
break; break;
} }
if (!match) { if (!match) {
err = -ENODEV;
dev_err(&adev->dev, "no matching children\n"); dev_err(&adev->dev, "no matching children\n");
goto out_clk_disable; goto out_clk_disable;
} }