iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cxl/pci: Remove unnecessary device reference management in sanitize work

Browse Source 
Given that any particular put_device() could be the final put of the
device, the fact that there are usages of cxlds->dev after
put_device(cxlds->dev) is a red flag. Drop the reference counting since
the device is pinned by being registered and will not be unregistered
without triggering the driver + workqueue to shutdown.

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Dan Williams 2023-09-29 14:44:46 -07:00
parent 6465e260f4
commit 76fe8713dd
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/cxl/pci.c
View File

@ -152,8 +152,6 @@ static void cxl_mbox_sanitize_work(struct work_struct *work)
mutex_lock(&mds->mbox_mutex); mutex_lock(&mds->mbox_mutex);
if (cxl_mbox_background_complete(cxlds)) { if (cxl_mbox_background_complete(cxlds)) {
mds->security.poll_tmo_secs = 0; mds->security.poll_tmo_secs = 0;
put_device(cxlds->dev);
if (mds->security.sanitize_node) if (mds->security.sanitize_node)
sysfs_notify_dirent(mds->security.sanitize_node); sysfs_notify_dirent(mds->security.sanitize_node);
@ -296,9 +294,6 @@ static int __cxl_pci_mbox_send_cmd(struct cxl_memdev_state *mds,
*/ */
if (mbox_cmd->opcode == CXL_MBOX_OP_SANITIZE) { if (mbox_cmd->opcode == CXL_MBOX_OP_SANITIZE) {
if (mds->security.poll) { if (mds->security.poll) {
/* hold the device throughout */
get_device(cxlds->dev);
/* give first timeout a second */ /* give first timeout a second */
timeout = 1; timeout = 1;
mds->security.poll_tmo_secs = timeout; mds->security.poll_tmo_secs = timeout;