iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ufs: Remove checks for PageError

Browse Source 
If read_mapping_page() encounters an error, it returns an errno, not
a page with PageError set, or a page that is not Uptodate, so this is
dead code.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
This commit is contained in:
Matthew Wilcox (Oracle) 2022-05-17 18:12:25 -04:00
parent b0c971e7b7
commit 771075e15e
2 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/ufs/dir.c
View File

@ -193,7 +193,7 @@ static struct page *ufs_get_page(struct inode *dir, unsigned long n)
if (!IS_ERR(page)) { if (!IS_ERR(page)) {
kmap(page); kmap(page);
if (unlikely(!PageChecked(page))) { if (unlikely(!PageChecked(page))) {
if (PageError(page) || !ufs_check_page(page)) if (!ufs_check_page(page))
goto fail; goto fail;
} }
} }

11
fs/ufs/util.c
View File

@ -264,17 +264,6 @@ struct page *ufs_get_locked_page(struct address_space *mapping,
put_page(page); put_page(page);
return NULL; return NULL;
} }
if (!PageUptodate(page) || PageError(page)) {
unlock_page(page);
put_page(page);
printk(KERN_ERR "ufs_change_blocknr: "
"can not read page: ino %lu, index: %lu\n",
inode->i_ino, index);
return ERR_PTR(-EIO);
}
} }
if (!page_has_buffers(page)) if (!page_has_buffers(page))
create_empty_buffers(page, 1 << inode->i_blkbits, 0); create_empty_buffers(page, 1 << inode->i_blkbits, 0);