iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tomoyo: Use sensible time interface

Browse Source 
There is no point in calling gettimeofday if only the seconds part of
the timespec is used. Use get_seconds() instead. It's not only the
proper interface it's also faster.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Kentaro Takeda <takedakn@nttdata.co.jp>
Cc: linux-security-module@vger.kernel.org
Link: http://lkml.kernel.org/r/20140611234607.775273584@linutronix.de
This commit is contained in:
Thomas Gleixner
2014-06-11 23:59:19 +00:00
parent f037c1171d
commit 77f4fa089c
2 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
security/tomoyo/audit.c
View File

@ -155,11 +155,9 @@ static char *tomoyo_print_header(struct tomoyo_request_info *r)
u8 i; u8 i;
if (!buffer) if (!buffer)
return NULL; return NULL;
{
struct timeval tv; tomoyo_convert_time(get_seconds(), &stamp);
do_gettimeofday(&tv);
tomoyo_convert_time(tv.tv_sec, &stamp);
}
pos = snprintf(buffer, tomoyo_buffer_len - 1, pos = snprintf(buffer, tomoyo_buffer_len - 1,
"#%04u/%02u/%02u %02u:%02u:%02u# profile=%u mode=%s " "#%04u/%02u/%02u %02u:%02u:%02u# profile=%u mode=%s "
"granted=%s (global-pid=%u) task={ pid=%u ppid=%u " "granted=%s (global-pid=%u) task={ pid=%u ppid=%u "

4
security/tomoyo/common.c
View File

@ -2267,13 +2267,11 @@ static unsigned int tomoyo_stat_modified[TOMOYO_MAX_POLICY_STAT];
*/ */
void tomoyo_update_stat(const u8 index) void tomoyo_update_stat(const u8 index)
{ {
struct timeval tv;
do_gettimeofday(&tv);
/* /*
* I don't use atomic operations because race condition is not fatal. * I don't use atomic operations because race condition is not fatal.
*/ */
tomoyo_stat_updated[index]++; tomoyo_stat_updated[index]++;
tomoyo_stat_modified[index] = tv.tv_sec; tomoyo_stat_modified[index] = get_seconds();
} }
/** /**