iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

klist: Fix object alignment on 64-bit.

Browse Source 
Commit c0e69a5bbc ("klist.c: bit 0 in pointer can't be used as flag")
intended to make sure that all klist objects were at least pointer size
aligned, but used the constant "4" which only works on 32-bit.

Use "sizeof(void *)" which is correct in all cases.

Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: stable <stable@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
David Miller 2011-02-13 16:37:07 -08:00 committed by Linus Torvalds
parent 091994cfb8
commit 795abaf1e4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/linux/klist.h
View File

@ -22,7 +22,7 @@ struct klist {
struct list_head k_list; struct list_head k_list;
void (*get)(struct klist_node *); void (*get)(struct klist_node *);
void (*put)(struct klist_node *); void (*put)(struct klist_node *);
} __attribute__ ((aligned (4))); } __attribute__ ((aligned (sizeof(void *))));
#define KLIST_INIT(_name, _get, _put) \ #define KLIST_INIT(_name, _get, _put) \
{ .k_lock = __SPIN_LOCK_UNLOCKED(_name.k_lock), \ { .k_lock = __SPIN_LOCK_UNLOCKED(_name.k_lock), \