iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

audit_compare_dname_path(): switch to const struct qstr *

Browse Source 
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2019-04-26 14:11:05 -04:00
parent 6921d4ebe4
commit 795d673af1
5 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/audit.h
View File

@ -231,7 +231,7 @@ extern int audit_comparator(const u32 left, const u32 op, const u32 right);
extern int audit_uid_comparator(kuid_t left, u32 op, kuid_t right); extern int audit_uid_comparator(kuid_t left, u32 op, kuid_t right);
extern int audit_gid_comparator(kgid_t left, u32 op, kgid_t right); extern int audit_gid_comparator(kgid_t left, u32 op, kgid_t right);
extern int parent_len(const char *path); extern int parent_len(const char *path);
extern int audit_compare_dname_path(const char *dname, const char *path, int plen); extern int audit_compare_dname_path(const struct qstr *dname, const char *path, int plen);
extern struct sk_buff *audit_make_reply(int seq, int type, int done, int multi, extern struct sk_buff *audit_make_reply(int seq, int type, int done, int multi,
const void *payload, int size); const void *payload, int size);
extern void audit_panic(const char *message); extern void audit_panic(const char *message);

2
kernel/audit_fsnotify.c
View File

@ -188,7 +188,7 @@ static int audit_mark_handle_event(struct fsnotify_group *group,
} }
if (mask & (FS_CREATE|FS_MOVED_TO|FS_DELETE|FS_MOVED_FROM)) { if (mask & (FS_CREATE|FS_MOVED_TO|FS_DELETE|FS_MOVED_FROM)) {
if (audit_compare_dname_path(dname->name, audit_mark->path, AUDIT_NAME_FULL)) if (audit_compare_dname_path(dname, audit_mark->path, AUDIT_NAME_FULL))
return 0; return 0;
audit_update_mark(audit_mark, inode); audit_update_mark(audit_mark, inode);
} else if (mask & (FS_DELETE_SELF|FS_UNMOUNT|FS_MOVE_SELF)) } else if (mask & (FS_DELETE_SELF|FS_UNMOUNT|FS_MOVE_SELF))

3
kernel/audit_watch.c
View File

@ -261,13 +261,12 @@ static void audit_update_watch(struct audit_parent *parent,
struct audit_watch *owatch, *nwatch, *nextw; struct audit_watch *owatch, *nwatch, *nextw;
struct audit_krule *r, *nextr; struct audit_krule *r, *nextr;
struct audit_entry *oentry, *nentry; struct audit_entry *oentry, *nentry;
const unsigned char *name = dname->name;
mutex_lock(&audit_filter_mutex); mutex_lock(&audit_filter_mutex);
/* Run all of the watches on this parent looking for the one that /* Run all of the watches on this parent looking for the one that
* matches the given dname */ * matches the given dname */
list_for_each_entry_safe(owatch, nextw, &parent->watches, wlist) { list_for_each_entry_safe(owatch, nextw, &parent->watches, wlist) {
if (audit_compare_dname_path(name, owatch->path, if (audit_compare_dname_path(dname, owatch->path,
AUDIT_NAME_FULL)) AUDIT_NAME_FULL))
continue; continue;

6
kernel/auditfilter.c
View File

@ -1290,12 +1290,12 @@ int parent_len(const char *path)
* @parentlen: length of the parent if known. Passing in AUDIT_NAME_FULL * @parentlen: length of the parent if known. Passing in AUDIT_NAME_FULL
* here indicates that we must compute this value. * here indicates that we must compute this value.
*/ */
int audit_compare_dname_path(const char *dname, const char *path, int parentlen) int audit_compare_dname_path(const struct qstr *dname, const char *path, int parentlen)
{ {
int dlen, pathlen; int dlen, pathlen;
const char *p; const char *p;
dlen = strlen(dname); dlen = dname->len;
pathlen = strlen(path); pathlen = strlen(path);
if (pathlen < dlen) if (pathlen < dlen)
return 1; return 1;
@ -1306,7 +1306,7 @@ int audit_compare_dname_path(const char *dname, const char *path, int parentlen)
p = path + parentlen; p = path + parentlen;
return strncmp(p, dname, dlen); return strncmp(p, dname->name, dlen);
} }
int audit_filter(int msgtype, unsigned int listtype) int audit_filter(int msgtype, unsigned int listtype)

4
kernel/auditsc.c
View File

@ -2045,7 +2045,7 @@ void __audit_inode_child(struct inode *parent,
{ {
struct audit_context *context = audit_context(); struct audit_context *context = audit_context();
struct inode *inode = d_backing_inode(dentry); struct inode *inode = d_backing_inode(dentry);
const char *dname = dentry->d_name.name; const struct qstr *dname = &dentry->d_name;
struct audit_names *n, *found_parent = NULL, *found_child = NULL; struct audit_names *n, *found_parent = NULL, *found_child = NULL;
struct audit_entry *e; struct audit_entry *e;
struct list_head *list = &audit_filter_list[AUDIT_FILTER_FS]; struct list_head *list = &audit_filter_list[AUDIT_FILTER_FS];
@ -2099,7 +2099,7 @@ void __audit_inode_child(struct inode *parent,
(n->type != type && n->type != AUDIT_TYPE_UNKNOWN)) (n->type != type && n->type != AUDIT_TYPE_UNKNOWN))
continue; continue;
if (!strcmp(dname, n->name->name) || if (!strcmp(dname->name, n->name->name) ||
!audit_compare_dname_path(dname, n->name->name, !audit_compare_dname_path(dname, n->name->name,
found_parent ? found_parent ?
found_parent->name_len : found_parent->name_len :