iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpio: mpc8xxx: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
This commit is contained in:
Uwe Kleine-König 2023-09-28 09:06:56 +02:00 committed by Bartosz Golaszewski
parent 0ede869808
commit 7a222f57d8
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpio/gpio-mpc8xxx.c
View File

@ -419,7 +419,7 @@ err:
return ret; return ret;
} }
static int mpc8xxx_remove(struct platform_device *pdev) static void mpc8xxx_remove(struct platform_device *pdev)
{ {
struct mpc8xxx_gpio_chip *mpc8xxx_gc = platform_get_drvdata(pdev); struct mpc8xxx_gpio_chip *mpc8xxx_gc = platform_get_drvdata(pdev);
@ -427,8 +427,6 @@ static int mpc8xxx_remove(struct platform_device *pdev)
irq_set_chained_handler_and_data(mpc8xxx_gc->irqn, NULL, NULL); irq_set_chained_handler_and_data(mpc8xxx_gc->irqn, NULL, NULL);
irq_domain_remove(mpc8xxx_gc->irq); irq_domain_remove(mpc8xxx_gc->irq);
} }
return 0;
} }
#ifdef CONFIG_ACPI #ifdef CONFIG_ACPI
@ -441,7 +439,7 @@ MODULE_DEVICE_TABLE(acpi, gpio_acpi_ids);
static struct platform_driver mpc8xxx_plat_driver = { static struct platform_driver mpc8xxx_plat_driver = {
.probe = mpc8xxx_probe, .probe = mpc8xxx_probe,
.remove = mpc8xxx_remove, .remove_new = mpc8xxx_remove,
.driver = { .driver = {
.name = "gpio-mpc8xxx", .name = "gpio-mpc8xxx",
.of_match_table = mpc8xxx_gpio_ids, .of_match_table = mpc8xxx_gpio_ids,