io_pgetevents: use __kernel_timespec
struct timespec is not y2038 safe. struct __kernel_timespec is the new y2038 safe structure for all syscalls that are using struct timespec. Update io_pgetevents interfaces to use struct __kernel_timespec. sigset_t also has different representations on 32 bit and 64 bit architectures. Hence, we need to support the following different syscalls: New y2038 safe syscalls: (Controlled by CONFIG_64BIT_TIME for 32 bit ABIs) Native 64 bit(unchanged) and native 32 bit : sys_io_pgetevents Compat : compat_sys_io_pgetevents_time64 Older y2038 unsafe syscalls: (Controlled by CONFIG_32BIT_COMPAT_TIME for 32 bit ABIs) Native 32 bit : sys_io_pgetevents_time32 Compat : compat_sys_io_pgetevents Note that io_getevents syscalls do not have a y2038 safe solution. Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This commit is contained in:
parent
e024707bcc
commit
7a35397f8c
84
fs/aio.c
84
fs/aio.c
@ -2062,11 +2062,13 @@ static long do_io_getevents(aio_context_t ctx_id,
|
|||||||
* specifies an infinite timeout. Note that the timeout pointed to by
|
* specifies an infinite timeout. Note that the timeout pointed to by
|
||||||
* timeout is relative. Will fail with -ENOSYS if not implemented.
|
* timeout is relative. Will fail with -ENOSYS if not implemented.
|
||||||
*/
|
*/
|
||||||
|
#if !defined(CONFIG_64BIT_TIME) || defined(CONFIG_64BIT)
|
||||||
|
|
||||||
SYSCALL_DEFINE5(io_getevents, aio_context_t, ctx_id,
|
SYSCALL_DEFINE5(io_getevents, aio_context_t, ctx_id,
|
||||||
long, min_nr,
|
long, min_nr,
|
||||||
long, nr,
|
long, nr,
|
||||||
struct io_event __user *, events,
|
struct io_event __user *, events,
|
||||||
struct timespec __user *, timeout)
|
struct __kernel_timespec __user *, timeout)
|
||||||
{
|
{
|
||||||
struct timespec64 ts;
|
struct timespec64 ts;
|
||||||
int ret;
|
int ret;
|
||||||
@ -2080,6 +2082,8 @@ SYSCALL_DEFINE5(io_getevents, aio_context_t, ctx_id,
|
|||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#endif
|
||||||
|
|
||||||
struct __aio_sigset {
|
struct __aio_sigset {
|
||||||
const sigset_t __user *sigmask;
|
const sigset_t __user *sigmask;
|
||||||
size_t sigsetsize;
|
size_t sigsetsize;
|
||||||
@ -2090,7 +2094,7 @@ SYSCALL_DEFINE6(io_pgetevents,
|
|||||||
long, min_nr,
|
long, min_nr,
|
||||||
long, nr,
|
long, nr,
|
||||||
struct io_event __user *, events,
|
struct io_event __user *, events,
|
||||||
struct timespec __user *, timeout,
|
struct __kernel_timespec __user *, timeout,
|
||||||
const struct __aio_sigset __user *, usig)
|
const struct __aio_sigset __user *, usig)
|
||||||
{
|
{
|
||||||
struct __aio_sigset ksig = { NULL, };
|
struct __aio_sigset ksig = { NULL, };
|
||||||
@ -2104,6 +2108,39 @@ SYSCALL_DEFINE6(io_pgetevents,
|
|||||||
if (usig && copy_from_user(&ksig, usig, sizeof(ksig)))
|
if (usig && copy_from_user(&ksig, usig, sizeof(ksig)))
|
||||||
return -EFAULT;
|
return -EFAULT;
|
||||||
|
|
||||||
|
ret = set_user_sigmask(ksig.sigmask, &ksigmask, &sigsaved, ksig.sigsetsize);
|
||||||
|
if (ret)
|
||||||
|
return ret;
|
||||||
|
|
||||||
|
ret = do_io_getevents(ctx_id, min_nr, nr, events, timeout ? &ts : NULL);
|
||||||
|
restore_user_sigmask(ksig.sigmask, &sigsaved);
|
||||||
|
if (signal_pending(current) && !ret)
|
||||||
|
ret = -ERESTARTNOHAND;
|
||||||
|
|
||||||
|
return ret;
|
||||||
|
}
|
||||||
|
|
||||||
|
#if defined(CONFIG_COMPAT_32BIT_TIME) && !defined(CONFIG_64BIT)
|
||||||
|
|
||||||
|
SYSCALL_DEFINE6(io_pgetevents_time32,
|
||||||
|
aio_context_t, ctx_id,
|
||||||
|
long, min_nr,
|
||||||
|
long, nr,
|
||||||
|
struct io_event __user *, events,
|
||||||
|
struct old_timespec32 __user *, timeout,
|
||||||
|
const struct __aio_sigset __user *, usig)
|
||||||
|
{
|
||||||
|
struct __aio_sigset ksig = { NULL, };
|
||||||
|
sigset_t ksigmask, sigsaved;
|
||||||
|
struct timespec64 ts;
|
||||||
|
int ret;
|
||||||
|
|
||||||
|
if (timeout && unlikely(get_old_timespec32(&ts, timeout)))
|
||||||
|
return -EFAULT;
|
||||||
|
|
||||||
|
if (usig && copy_from_user(&ksig, usig, sizeof(ksig)))
|
||||||
|
return -EFAULT;
|
||||||
|
|
||||||
|
|
||||||
ret = set_user_sigmask(ksig.sigmask, &ksigmask, &sigsaved, ksig.sigsetsize);
|
ret = set_user_sigmask(ksig.sigmask, &ksigmask, &sigsaved, ksig.sigsetsize);
|
||||||
if (ret)
|
if (ret)
|
||||||
@ -2117,7 +2154,10 @@ SYSCALL_DEFINE6(io_pgetevents,
|
|||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
#ifdef CONFIG_COMPAT
|
#endif
|
||||||
|
|
||||||
|
#if defined(CONFIG_COMPAT_32BIT_TIME)
|
||||||
|
|
||||||
COMPAT_SYSCALL_DEFINE5(io_getevents, compat_aio_context_t, ctx_id,
|
COMPAT_SYSCALL_DEFINE5(io_getevents, compat_aio_context_t, ctx_id,
|
||||||
compat_long_t, min_nr,
|
compat_long_t, min_nr,
|
||||||
compat_long_t, nr,
|
compat_long_t, nr,
|
||||||
@ -2136,12 +2176,17 @@ COMPAT_SYSCALL_DEFINE5(io_getevents, compat_aio_context_t, ctx_id,
|
|||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#endif
|
||||||
|
|
||||||
|
#ifdef CONFIG_COMPAT
|
||||||
|
|
||||||
struct __compat_aio_sigset {
|
struct __compat_aio_sigset {
|
||||||
compat_sigset_t __user *sigmask;
|
compat_sigset_t __user *sigmask;
|
||||||
compat_size_t sigsetsize;
|
compat_size_t sigsetsize;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
#if defined(CONFIG_COMPAT_32BIT_TIME)
|
||||||
|
|
||||||
COMPAT_SYSCALL_DEFINE6(io_pgetevents,
|
COMPAT_SYSCALL_DEFINE6(io_pgetevents,
|
||||||
compat_aio_context_t, ctx_id,
|
compat_aio_context_t, ctx_id,
|
||||||
compat_long_t, min_nr,
|
compat_long_t, min_nr,
|
||||||
@ -2172,4 +2217,37 @@ COMPAT_SYSCALL_DEFINE6(io_pgetevents,
|
|||||||
|
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#endif
|
||||||
|
|
||||||
|
COMPAT_SYSCALL_DEFINE6(io_pgetevents_time64,
|
||||||
|
compat_aio_context_t, ctx_id,
|
||||||
|
compat_long_t, min_nr,
|
||||||
|
compat_long_t, nr,
|
||||||
|
struct io_event __user *, events,
|
||||||
|
struct __kernel_timespec __user *, timeout,
|
||||||
|
const struct __compat_aio_sigset __user *, usig)
|
||||||
|
{
|
||||||
|
struct __compat_aio_sigset ksig = { NULL, };
|
||||||
|
sigset_t ksigmask, sigsaved;
|
||||||
|
struct timespec64 t;
|
||||||
|
int ret;
|
||||||
|
|
||||||
|
if (timeout && get_timespec64(&t, timeout))
|
||||||
|
return -EFAULT;
|
||||||
|
|
||||||
|
if (usig && copy_from_user(&ksig, usig, sizeof(ksig)))
|
||||||
|
return -EFAULT;
|
||||||
|
|
||||||
|
ret = set_compat_user_sigmask(ksig.sigmask, &ksigmask, &sigsaved, ksig.sigsetsize);
|
||||||
|
if (ret)
|
||||||
|
return ret;
|
||||||
|
|
||||||
|
ret = do_io_getevents(ctx_id, min_nr, nr, events, timeout ? &t : NULL);
|
||||||
|
restore_user_sigmask(ksig.sigmask, &sigsaved);
|
||||||
|
if (signal_pending(current) && !ret)
|
||||||
|
ret = -ERESTARTNOHAND;
|
||||||
|
|
||||||
|
return ret;
|
||||||
|
}
|
||||||
#endif
|
#endif
|
||||||
|
@ -562,6 +562,12 @@ asmlinkage long compat_sys_io_pgetevents(compat_aio_context_t ctx_id,
|
|||||||
struct io_event __user *events,
|
struct io_event __user *events,
|
||||||
struct old_timespec32 __user *timeout,
|
struct old_timespec32 __user *timeout,
|
||||||
const struct __compat_aio_sigset __user *usig);
|
const struct __compat_aio_sigset __user *usig);
|
||||||
|
asmlinkage long compat_sys_io_pgetevents_time64(compat_aio_context_t ctx_id,
|
||||||
|
compat_long_t min_nr,
|
||||||
|
compat_long_t nr,
|
||||||
|
struct io_event __user *events,
|
||||||
|
struct __kernel_timespec __user *timeout,
|
||||||
|
const struct __compat_aio_sigset __user *usig);
|
||||||
|
|
||||||
/* fs/cookies.c */
|
/* fs/cookies.c */
|
||||||
asmlinkage long compat_sys_lookup_dcookie(u32, u32, char __user *, compat_size_t);
|
asmlinkage long compat_sys_lookup_dcookie(u32, u32, char __user *, compat_size_t);
|
||||||
|
@ -296,12 +296,18 @@ asmlinkage long sys_io_getevents(aio_context_t ctx_id,
|
|||||||
long min_nr,
|
long min_nr,
|
||||||
long nr,
|
long nr,
|
||||||
struct io_event __user *events,
|
struct io_event __user *events,
|
||||||
struct timespec __user *timeout);
|
struct __kernel_timespec __user *timeout);
|
||||||
asmlinkage long sys_io_pgetevents(aio_context_t ctx_id,
|
asmlinkage long sys_io_pgetevents(aio_context_t ctx_id,
|
||||||
long min_nr,
|
long min_nr,
|
||||||
long nr,
|
long nr,
|
||||||
struct io_event __user *events,
|
struct io_event __user *events,
|
||||||
struct timespec __user *timeout,
|
struct __kernel_timespec __user *timeout,
|
||||||
|
const struct __aio_sigset *sig);
|
||||||
|
asmlinkage long sys_io_pgetevents_time32(aio_context_t ctx_id,
|
||||||
|
long min_nr,
|
||||||
|
long nr,
|
||||||
|
struct io_event __user *events,
|
||||||
|
struct old_timespec32 __user *timeout,
|
||||||
const struct __aio_sigset *sig);
|
const struct __aio_sigset *sig);
|
||||||
|
|
||||||
/* fs/xattr.c */
|
/* fs/xattr.c */
|
||||||
|
Loading…
Reference in New Issue
Block a user