iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: loopback: use the attribute groups, not group

Browse Source 
We should use the attribute groups, not group, for the device, so
add and remove it.  No one should ever be updating a sysfs group for a
device, as that can be pretty dangerous if you don't duplicate _all_
existing attribute for that device, and I don't think we were doing that
here.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Greg Kroah-Hartman 2015-03-31 23:02:34 +02:00
parent 5679f783b1
commit 7a51b9362b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/greybus/loopback.c
View File

@ -343,7 +343,7 @@ static int gb_loopback_connection_init(struct gb_connection *connection)
gb->connection = connection;
connection->private = gb;
retval = sysfs_update_group(&connection->dev.kobj, &loopback_group);
retval = sysfs_create_groups(&connection->dev.kobj, loopback_groups);
if (retval)
goto error;
@ -372,7 +372,7 @@ static void gb_loopback_connection_exit(struct gb_connection *connection)
if (!IS_ERR_OR_NULL(gb->task))
kthread_stop(gb->task);
sysfs_remove_group(&connection->dev.kobj, &loopback_group);
sysfs_remove_groups(&connection->dev.kobj, loopback_groups);
kfree(gb);
}