iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

brcmfmac: Configure keep-alive packet on suspend

Browse Source 
When entering suspend as a client station with wowlan enabled,
the Wi-Fi link is supposed to be maintained. In that state, no
more data is generated from client side, and the link stays idle
as long the station is suspended and as long the AP as no data to
transmit.

However, most of the APs kick-off such 'inactive' stations after
few minutes, causing unexpected disconnect (reconnect, etc...).

The usual way to prevent this is to submit a Null function frame
periodically as a keep-alive. This is something that can be host
/software generated (e.g. wpa_supplicant), but that needs to be
offloaded to the Wi-Fi controller in case of suspended host.

This change enables firmware generated keep-alive frames when
entering wowlan suspend, using the 'mkeep_alive' IOVAR.

Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1637596046-21651-1-git-send-email-loic.poulain@linaro.org
This commit is contained in:
Loic Poulain 2021-11-22 16:47:26 +01:00 committed by Kalle Valo
parent d1e69b5492
commit 7a6cfe28ae
2 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
View File

@ -3901,6 +3901,24 @@ static void brcmf_configure_wowl(struct brcmf_cfg80211_info *cfg,
cfg->wowl.active = true;
}
static int brcmf_keepalive_start(struct brcmf_if *ifp, unsigned int interval)
{
struct brcmf_mkeep_alive_pkt_le kalive = {0};
int ret = 0;
/* Configure Null function/data keepalive */
kalive.version = cpu_to_le16(1);
kalive.period_msec = cpu_to_le16(interval * MSEC_PER_SEC);
kalive.len_bytes = cpu_to_le16(0);
kalive.keep_alive_id = cpu_to_le16(0);
ret = brcmf_fil_iovar_data_set(ifp, "mkeep_alive", &kalive, sizeof(kalive));
if (ret)
brcmf_err("keep-alive packet config failed, ret=%d\n", ret);
return ret;
}
static s32 brcmf_cfg80211_suspend(struct wiphy *wiphy,
struct cfg80211_wowlan *wowl)
{
@ -3947,6 +3965,9 @@ static s32 brcmf_cfg80211_suspend(struct wiphy *wiphy,
} else {
/* Configure WOWL paramaters */
brcmf_configure_wowl(cfg, ifp, wowl);
/* Prevent disassociation due to inactivity with keep-alive */
brcmf_keepalive_start(ifp, 30);
}
exit:

19
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil_types.h
View File

@ -1052,4 +1052,23 @@ struct brcmf_gscan_config {
struct brcmf_gscan_bucket_config bucket[1];
};
/**
* struct brcmf_mkeep_alive_pkt_le - configuration data for keep-alive frame.
*
* @version: version for mkeep_alive
* @length: length of fixed parameters in the structure.
* @period_msec: keep-alive period in milliseconds.
* @len_bytes: size of the data.
* @keep_alive_id: ID (0 - 3).
* @data: keep-alive frame data.
*/
struct brcmf_mkeep_alive_pkt_le {
__le16 version;
__le16 length;
__le32 period_msec;
__le16 len_bytes;
u8 keep_alive_id;
u8 data[0];
} __packed;
#endif /* FWIL_TYPES_H_ */