iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mfd: abx500-core: Fix compiler warning larger stack frame

Browse Source 
On systems with CONFIG_FRAME_WARN=1024, compiler warns the allocation of
an object of struct device on stack. Make the allocation dynamically to
fix the warning. Also change the caller's return type to int so as to
account for error handling.

drivers/mfd/abx500-core.c: In function ‘abx500_dump_all_banks’:
drivers/mfd/abx500-core.c:167:1: warning: the frame size of 1032 bytes
is larger than 1024 bytes [-Wframe-larger-than=]

Signed-off-by: Aurabindo J <mail@aurabindo.in>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Jay Aurabind 2014-05-21 22:49:54 +05:30 committed by Lee Jones
parent 58a9e5b983
commit 7abafa0a66
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/mfd/abx500-core.c
View File

@ -151,19 +151,23 @@ int abx500_startup_irq_enabled(struct device *dev, unsigned int irq)
}
EXPORT_SYMBOL(abx500_startup_irq_enabled);
void abx500_dump_all_banks(void)
int abx500_dump_all_banks(void)
{
struct abx500_ops *ops;
struct device dummy_child = {NULL};
struct device *dummy_child;
struct abx500_device_entry *dev_entry;
dummy_child = kzalloc(sizeof(struct device), GFP_KERNEL);
if (!dummy_child)
return -ENOMEM;
list_for_each_entry(dev_entry, &abx500_list, list) {
dummy_child.parent = dev_entry->dev;
dummy_child->parent = dev_entry->dev;
ops = &dev_entry->ops;
if ((ops != NULL) && (ops->dump_all_banks != NULL))
ops->dump_all_banks(&dummy_child);
ops->dump_all_banks(dummy_child);
}
kfree(dummy_child);
}
EXPORT_SYMBOL(abx500_dump_all_banks);

2
include/linux/mfd/abx500.h
View File

@ -330,7 +330,7 @@ int abx500_mask_and_set_register_interruptible(struct device *dev, u8 bank,
int abx500_get_chip_id(struct device *dev);
int abx500_event_registers_startup_state_get(struct device *dev, u8 *event);
int abx500_startup_irq_enabled(struct device *dev, unsigned int irq);
void abx500_dump_all_banks(void);
int abx500_dump_all_banks(void);
struct abx500_ops {
int (*get_chip_id) (struct device *);