iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

be2net: clear promiscuous bits in adapter->flags while disabling promiscuous mode

Browse Source 
We should clear promiscuous bits in adapter->flags while disabling promiscuous
mode. Else we will not put interface back into VLAN promisc mode if the vlans
already added exceeds the maximum limit.

Signed-off-by: Kalesh AP <kalesh.purayil@emulex.com>
Signed-off-by: Somnath Kotur <somnath.kotur@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Somnath kotur 2014-03-03 14:24:43 +05:30 committed by David S. Miller
parent c502224efb
commit 7ad09458a5
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/net/ethernet/emulex/benet/be_main.c
View File

@ -1157,6 +1157,14 @@ ret:
return status;
}
static void be_clear_promisc(struct be_adapter *adapter)
{
adapter->promiscuous = false;
adapter->flags &= ~BE_FLAGS_VLAN_PROMISC;
be_cmd_rx_filter(adapter, IFF_PROMISC, OFF);
}
static void be_set_rx_mode(struct net_device *netdev)
{
struct be_adapter *adapter = netdev_priv(netdev);
@ -1170,9 +1178,7 @@ static void be_set_rx_mode(struct net_device *netdev)
/* BE was previously in promiscuous mode; disable it */
if (adapter->promiscuous) {
adapter->promiscuous = false;
be_cmd_rx_filter(adapter, IFF_PROMISC, OFF);
be_clear_promisc(adapter);
if (adapter->vlans_added)
be_vid_config(adapter);
}