platform/x86: intel_ips: fix kernel-doc formatting
Fix kernel-doc function notation and comment formatting to prevent warnings from scripts/kernel-doc. for drivers/platform/x86/intel_ips.c: 595: warning: No description found for return value of 'mcp_exceeded' 624: warning: No description found for return value of 'cpu_exceeded' 650: warning: No description found for return value of 'mch_exceeded' 745: warning: bad line: cpu+ gpu+ cpu+gpu- cpu-gpu+ cpu-gpu- 746: warning: bad line: cpu < gpu < cpu+gpu+ cpu+ gpu+ nothing 753: warning: No description found for return value of 'ips_adjust' 747: warning: bad line: cpu < gpu >= cpu+gpu-(mcp<) cpu+gpu-(mcp<) gpu- gpu- 748: warning: bad line: cpu >= gpu < cpu-gpu+(mcp<) cpu- cpu-gpu+(mcp<) cpu- 749: warning: bad line: cpu >= gpu >= cpu-gpu- cpu-gpu- cpu-gpu- cpu-gpu- 945: warning: No description found for return value of 'ips_monitor' 1151: warning: No description found for return value of 'ips_irq_handler' 1301: warning: Function parameter or member 'ips' not described in 'ips_detect_cpu' 1302: warning: No description found for return value of 'ips_detect_cpu' 1358: warning: No description found for return value of 'ips_get_i915_syms' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Cc: platform-driver-x86@vger.kernel.org Link: https://lore.kernel.org/r/20231206060120.4816-1-rdunlap@infradead.org Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
This commit is contained in:
parent
17fe3ec0c1
commit
7bcd032370
@ -590,6 +590,8 @@ static void ips_disable_gpu_turbo(struct ips_driver *ips)
|
|||||||
* @ips: IPS driver struct
|
* @ips: IPS driver struct
|
||||||
*
|
*
|
||||||
* Check whether the MCP is over its thermal or power budget.
|
* Check whether the MCP is over its thermal or power budget.
|
||||||
|
*
|
||||||
|
* Returns: %true if the temp or power has exceeded its maximum, else %false
|
||||||
*/
|
*/
|
||||||
static bool mcp_exceeded(struct ips_driver *ips)
|
static bool mcp_exceeded(struct ips_driver *ips)
|
||||||
{
|
{
|
||||||
@ -619,6 +621,8 @@ static bool mcp_exceeded(struct ips_driver *ips)
|
|||||||
* @cpu: CPU number to check
|
* @cpu: CPU number to check
|
||||||
*
|
*
|
||||||
* Check a given CPU's average temp or power is over its limit.
|
* Check a given CPU's average temp or power is over its limit.
|
||||||
|
*
|
||||||
|
* Returns: %true if the temp or power has exceeded its maximum, else %false
|
||||||
*/
|
*/
|
||||||
static bool cpu_exceeded(struct ips_driver *ips, int cpu)
|
static bool cpu_exceeded(struct ips_driver *ips, int cpu)
|
||||||
{
|
{
|
||||||
@ -645,6 +649,8 @@ static bool cpu_exceeded(struct ips_driver *ips, int cpu)
|
|||||||
* @ips: IPS driver struct
|
* @ips: IPS driver struct
|
||||||
*
|
*
|
||||||
* Check the MCH temp & power against their maximums.
|
* Check the MCH temp & power against their maximums.
|
||||||
|
*
|
||||||
|
* Returns: %true if the temp or power has exceeded its maximum, else %false
|
||||||
*/
|
*/
|
||||||
static bool mch_exceeded(struct ips_driver *ips)
|
static bool mch_exceeded(struct ips_driver *ips)
|
||||||
{
|
{
|
||||||
@ -742,12 +748,13 @@ static void update_turbo_limits(struct ips_driver *ips)
|
|||||||
* - down (at TDP limit)
|
* - down (at TDP limit)
|
||||||
* - adjust both CPU and GPU down if possible
|
* - adjust both CPU and GPU down if possible
|
||||||
*
|
*
|
||||||
cpu+ gpu+ cpu+gpu- cpu-gpu+ cpu-gpu-
|
* |cpu+ gpu+ cpu+gpu- cpu-gpu+ cpu-gpu-
|
||||||
cpu < gpu < cpu+gpu+ cpu+ gpu+ nothing
|
* cpu < gpu < |cpu+gpu+ cpu+ gpu+ nothing
|
||||||
cpu < gpu >= cpu+gpu-(mcp<) cpu+gpu-(mcp<) gpu- gpu-
|
* cpu < gpu >= |cpu+gpu-(mcp<) cpu+gpu-(mcp<) gpu- gpu-
|
||||||
cpu >= gpu < cpu-gpu+(mcp<) cpu- cpu-gpu+(mcp<) cpu-
|
* cpu >= gpu < |cpu-gpu+(mcp<) cpu- cpu-gpu+(mcp<) cpu-
|
||||||
cpu >= gpu >= cpu-gpu- cpu-gpu- cpu-gpu- cpu-gpu-
|
* cpu >= gpu >=|cpu-gpu- cpu-gpu- cpu-gpu- cpu-gpu-
|
||||||
*
|
*
|
||||||
|
* Returns: %0
|
||||||
*/
|
*/
|
||||||
static int ips_adjust(void *data)
|
static int ips_adjust(void *data)
|
||||||
{
|
{
|
||||||
@ -935,11 +942,13 @@ static void monitor_timeout(struct timer_list *t)
|
|||||||
* @data: ips driver structure
|
* @data: ips driver structure
|
||||||
*
|
*
|
||||||
* This is the main function for the IPS driver. It monitors power and
|
* This is the main function for the IPS driver. It monitors power and
|
||||||
* tempurature in the MCP and adjusts CPU and GPU power clams accordingly.
|
* temperature in the MCP and adjusts CPU and GPU power clamps accordingly.
|
||||||
*
|
*
|
||||||
* We keep a 5s moving average of power consumption and tempurature. Using
|
* We keep a 5s moving average of power consumption and temperature. Using
|
||||||
* that data, along with CPU vs GPU preference, we adjust the power clamps
|
* that data, along with CPU vs GPU preference, we adjust the power clamps
|
||||||
* up or down.
|
* up or down.
|
||||||
|
*
|
||||||
|
* Returns: %0 on success or -errno on error
|
||||||
*/
|
*/
|
||||||
static int ips_monitor(void *data)
|
static int ips_monitor(void *data)
|
||||||
{
|
{
|
||||||
@ -1146,6 +1155,8 @@ static void dump_thermal_info(struct ips_driver *ips)
|
|||||||
* Handle temperature limit trigger events, generally by lowering the clamps.
|
* Handle temperature limit trigger events, generally by lowering the clamps.
|
||||||
* If we're at a critical limit, we clamp back to the lowest possible value
|
* If we're at a critical limit, we clamp back to the lowest possible value
|
||||||
* to prevent emergency shutdown.
|
* to prevent emergency shutdown.
|
||||||
|
*
|
||||||
|
* Returns: IRQ_NONE or IRQ_HANDLED
|
||||||
*/
|
*/
|
||||||
static irqreturn_t ips_irq_handler(int irq, void *arg)
|
static irqreturn_t ips_irq_handler(int irq, void *arg)
|
||||||
{
|
{
|
||||||
@ -1293,9 +1304,12 @@ static void ips_debugfs_init(struct ips_driver *ips)
|
|||||||
|
|
||||||
/**
|
/**
|
||||||
* ips_detect_cpu - detect whether CPU supports IPS
|
* ips_detect_cpu - detect whether CPU supports IPS
|
||||||
|
* @ips: IPS driver struct
|
||||||
*
|
*
|
||||||
* Walk our list and see if we're on a supported CPU. If we find one,
|
* Walk our list and see if we're on a supported CPU. If we find one,
|
||||||
* return the limits for it.
|
* return the limits for it.
|
||||||
|
*
|
||||||
|
* Returns: the &ips_mcp_limits struct that matches the boot CPU or %NULL
|
||||||
*/
|
*/
|
||||||
static struct ips_mcp_limits *ips_detect_cpu(struct ips_driver *ips)
|
static struct ips_mcp_limits *ips_detect_cpu(struct ips_driver *ips)
|
||||||
{
|
{
|
||||||
@ -1352,6 +1366,8 @@ static struct ips_mcp_limits *ips_detect_cpu(struct ips_driver *ips)
|
|||||||
* monitor and control graphics turbo mode. If we can find them, we can
|
* monitor and control graphics turbo mode. If we can find them, we can
|
||||||
* enable graphics turbo, otherwise we must disable it to avoid exceeding
|
* enable graphics turbo, otherwise we must disable it to avoid exceeding
|
||||||
* thermal and power limits in the MCP.
|
* thermal and power limits in the MCP.
|
||||||
|
*
|
||||||
|
* Returns: %true if the required symbols are found, else %false
|
||||||
*/
|
*/
|
||||||
static bool ips_get_i915_syms(struct ips_driver *ips)
|
static bool ips_get_i915_syms(struct ips_driver *ips)
|
||||||
{
|
{
|
||||||
|
Loading…
x
Reference in New Issue
Block a user