iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: ethtool: netlink: introduce ethnl_update_bool()

Browse Source 
Due to the fact that the kernel-side data structures have been carried
over from the ioctl-based ethtool, we are now in the situation where we
have an ethnl_update_bool32() function, but the plain function that
operates on a boolean value kept in an actual u8 netlink attribute
doesn't exist.

With new ethtool features that are exposed solely over netlink, the
kernel data structures will use the "bool" type, so we will need this
kind of helper. Introduce it now; it's needed for things like
verify-disabled for the MAC merge configuration.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Vladimir Oltean 2023-01-19 14:26:53 +02:00 committed by David S. Miller
parent e38553bdc3
commit 7c494a7749
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
net/ethtool/netlink.h
View File

@ -111,6 +111,32 @@ static inline void ethnl_update_u8(u8 *dst, const struct nlattr *attr,
*mod = true;
}
/**
* ethnl_update_bool() - update bool from NLA_U8 attribute
* @dst: value to update
* @attr: netlink attribute with new value or null
* @mod: pointer to bool for modification tracking
*
* Use the u8 value from NLA_U8 netlink attribute @attr to set bool variable
* pointed to by @dst to false (if zero) or 1 (if not); do nothing if @attr is
* null. Bool pointed to by @mod is set to true if this function changed the
* logical value of *dst, otherwise it is left as is.
*/
static inline void ethnl_update_bool(bool *dst, const struct nlattr *attr,
bool *mod)
{
u8 val;
if (!attr)
return;
val = !!nla_get_u8(attr);
if (*dst == val)
return;
*dst = val;
*mod = true;
}
/**
* ethnl_update_bool32() - update u32 used as bool from NLA_U8 attribute
* @dst: value to update