iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

padata: Remove superfluous might_sleep

Browse Source 
might_sleep() was placed before mutex_lock() in some places.
We remove them because mutex_lock() does might_sleep() too.

Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Steffen Klassert 2010-04-29 14:40:53 +02:00 committed by Herbert Xu
parent e2cb2f1c2c
commit 7d0d2d385c
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
kernel/padata.c
View File

@ -443,8 +443,6 @@ int padata_set_cpumask(struct padata_instance *pinst,
struct parallel_data *pd; struct parallel_data *pd;
int err = 0; int err = 0;
might_sleep();
mutex_lock(&pinst->lock); mutex_lock(&pinst->lock);
pd = padata_alloc_pd(pinst, cpumask); pd = padata_alloc_pd(pinst, cpumask);
@ -489,8 +487,6 @@ int padata_add_cpu(struct padata_instance *pinst, int cpu)
{ {
int err; int err;
might_sleep();
mutex_lock(&pinst->lock); mutex_lock(&pinst->lock);
cpumask_set_cpu(cpu, pinst->cpumask); cpumask_set_cpu(cpu, pinst->cpumask);
@ -527,8 +523,6 @@ int padata_remove_cpu(struct padata_instance *pinst, int cpu)
{ {
int err; int err;
might_sleep();
mutex_lock(&pinst->lock); mutex_lock(&pinst->lock);
cpumask_clear_cpu(cpu, pinst->cpumask); cpumask_clear_cpu(cpu, pinst->cpumask);
@ -547,8 +541,6 @@ EXPORT_SYMBOL(padata_remove_cpu);
*/ */
void padata_start(struct padata_instance *pinst) void padata_start(struct padata_instance *pinst)
{ {
might_sleep();
mutex_lock(&pinst->lock); mutex_lock(&pinst->lock);
pinst->flags |= PADATA_INIT; pinst->flags |= PADATA_INIT;
mutex_unlock(&pinst->lock); mutex_unlock(&pinst->lock);
@ -562,8 +554,6 @@ EXPORT_SYMBOL(padata_start);
*/ */
void padata_stop(struct padata_instance *pinst) void padata_stop(struct padata_instance *pinst)
{ {
might_sleep();
mutex_lock(&pinst->lock); mutex_lock(&pinst->lock);
pinst->flags &= ~PADATA_INIT; pinst->flags &= ~PADATA_INIT;
mutex_unlock(&pinst->lock); mutex_unlock(&pinst->lock);