iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

USB: xhci: replace if-elseif-else with switch-case

Browse Source 
Replace if-elseif-else with switch-case
to keep the code consistent which is semantically same

Switch-case is used here,
http://www.spinics.net/lists/linux-usb/msg17201.html
Making consistent at other places in usb/core

Also easier to read and maintain when USB4.0, 5.0, ... comes

Signed-off-by: Viral Mehta <viral.mehta@einfochips.com>
Tested-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Viral Mehta 2009-05-05 15:54:23 +05:30 committed by Greg Kroah-Hartman
parent 527c6d7f18
commit 7dd19e69d1
1 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
drivers/usb/core/hcd.c
View File

@ -488,28 +488,39 @@ static int rh_call_control (struct usb_hcd *hcd, struct urb *urb)
case DeviceRequest | USB_REQ_GET_DESCRIPTOR: case DeviceRequest | USB_REQ_GET_DESCRIPTOR:
switch (wValue & 0xff00) { switch (wValue & 0xff00) {
case USB_DT_DEVICE << 8: case USB_DT_DEVICE << 8:
if (hcd->driver->flags & HCD_USB3) switch (hcd->driver->flags & HCD_MASK) {
case HCD_USB3:
bufp = usb3_rh_dev_descriptor; bufp = usb3_rh_dev_descriptor;
else if (hcd->driver->flags & HCD_USB2) break;
case HCD_USB2:
bufp = usb2_rh_dev_descriptor; bufp = usb2_rh_dev_descriptor;
else if (hcd->driver->flags & HCD_USB11) break;
case HCD_USB11:
bufp = usb11_rh_dev_descriptor; bufp = usb11_rh_dev_descriptor;
else break;
default:
goto error; goto error;
}
len = 18; len = 18;
if (hcd->has_tt) if (hcd->has_tt)
patch_protocol = 1; patch_protocol = 1;
break; break;
case USB_DT_CONFIG << 8: case USB_DT_CONFIG << 8:
if (hcd->driver->flags & HCD_USB3) { switch (hcd->driver->flags & HCD_MASK) {
case HCD_USB3:
bufp = ss_rh_config_descriptor; bufp = ss_rh_config_descriptor;
len = sizeof ss_rh_config_descriptor; len = sizeof ss_rh_config_descriptor;
} else if (hcd->driver->flags & HCD_USB2) { break;
case HCD_USB2:
bufp = hs_rh_config_descriptor; bufp = hs_rh_config_descriptor;
len = sizeof hs_rh_config_descriptor; len = sizeof hs_rh_config_descriptor;
} else { break;
case HCD_USB11:
bufp = fs_rh_config_descriptor; bufp = fs_rh_config_descriptor;
len = sizeof fs_rh_config_descriptor; len = sizeof fs_rh_config_descriptor;
break;
default:
goto error;
} }
if (device_can_wakeup(&hcd->self.root_hub->dev)) if (device_can_wakeup(&hcd->self.root_hub->dev))
patch_wakeup = 1; patch_wakeup = 1;