iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: vsp1: Use platform_get_irq() to get the interrupt

Browse Source 
platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
This commit is contained in:
Lad Prabhakar 2022-01-11 01:23:02 +01:00 committed by Mauro Carvalho Chehab
parent c9352df713
commit 7dee2cf054
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/media/platform/vsp1/vsp1_drv.c
View File

@ -794,9 +794,9 @@ static int vsp1_probe(struct platform_device *pdev)
{ {
struct vsp1_device *vsp1; struct vsp1_device *vsp1;
struct device_node *fcp_node; struct device_node *fcp_node;
struct resource *irq;
unsigned int i; unsigned int i;
int ret; int ret;
int irq;
vsp1 = devm_kzalloc(&pdev->dev, sizeof(*vsp1), GFP_KERNEL); vsp1 = devm_kzalloc(&pdev->dev, sizeof(*vsp1), GFP_KERNEL);
if (vsp1 == NULL) if (vsp1 == NULL)
@ -813,14 +813,12 @@ static int vsp1_probe(struct platform_device *pdev)
if (IS_ERR(vsp1->mmio)) if (IS_ERR(vsp1->mmio))
return PTR_ERR(vsp1->mmio); return PTR_ERR(vsp1->mmio);
irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); irq = platform_get_irq(pdev, 0);
if (!irq) { if (irq < 0)
dev_err(&pdev->dev, "missing IRQ\n"); return irq;
return -EINVAL;
}
ret = devm_request_irq(&pdev->dev, irq->start, vsp1_irq_handler, ret = devm_request_irq(&pdev->dev, irq, vsp1_irq_handler,
IRQF_SHARED, dev_name(&pdev->dev), vsp1); IRQF_SHARED, dev_name(&pdev->dev), vsp1);
if (ret < 0) { if (ret < 0) {
dev_err(&pdev->dev, "failed to request IRQ\n"); dev_err(&pdev->dev, "failed to request IRQ\n");
return ret; return ret;