iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

md: fix some issues with alloc_disk_sb()

Browse Source 
1/ don't print a warning if allocation fails.
 page_alloc() does that already.
2/ always check return status for error.

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
This commit is contained in:
NeilBrown 2016-11-02 14:16:49 +11:00 committed by Shaohua Li
parent cbb3873236
commit 7f0f0d87fa
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/md/md.c
View File

@ -684,11 +684,8 @@ static inline sector_t calc_dev_sboffset(struct md_rdev *rdev)
static int alloc_disk_sb(struct md_rdev *rdev) static int alloc_disk_sb(struct md_rdev *rdev)
{ {
rdev->sb_page = alloc_page(GFP_KERNEL); rdev->sb_page = alloc_page(GFP_KERNEL);
if (!rdev->sb_page) { if (!rdev->sb_page)
printk(KERN_ALERT "md: out of memory.\n");
return -ENOMEM; return -ENOMEM;
}
return 0; return 0;
} }
@ -8788,14 +8785,17 @@ static int read_rdev(struct mddev *mddev, struct md_rdev *rdev)
* variable in case we err in the future * variable in case we err in the future
*/ */
rdev->sb_page = NULL; rdev->sb_page = NULL;
alloc_disk_sb(rdev); err = alloc_disk_sb(rdev);
if (err == 0) {
ClearPageUptodate(rdev->sb_page); ClearPageUptodate(rdev->sb_page);
rdev->sb_loaded = 0; rdev->sb_loaded = 0;
err = super_types[mddev->major_version].load_super(rdev, NULL, mddev->minor_version); err = super_types[mddev->major_version].
load_super(rdev, NULL, mddev->minor_version);
}
if (err < 0) { if (err < 0) {
pr_warn("%s: %d Could not reload rdev(%d) err: %d. Restoring old values\n", pr_warn("%s: %d Could not reload rdev(%d) err: %d. Restoring old values\n",
__func__, __LINE__, rdev->desc_nr, err); __func__, __LINE__, rdev->desc_nr, err);
if (rdev->sb_page)
put_page(rdev->sb_page); put_page(rdev->sb_page);
rdev->sb_page = swapout; rdev->sb_page = swapout;
rdev->sb_loaded = 1; rdev->sb_loaded = 1;