iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ATM]: [he] don't hold the device lock when upcalling

Browse Source 
This can create a deadlock/lock ordering problem with other layers
that want to use the transmit (or other) path of the card at that
time.

Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Chas Williams 2006-09-19 12:59:11 -07:00 committed by David S. Miller
parent 79e453d49b
commit 7f81dc0097
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/atm/he.c
View File

@ -1928,7 +1928,9 @@ he_service_rbrq(struct he_dev *he_dev, int group)
#ifdef notdef #ifdef notdef
ATM_SKB(skb)->vcc = vcc; ATM_SKB(skb)->vcc = vcc;
#endif #endif
spin_unlock(&he_dev->global_lock);
vcc->push(vcc, skb); vcc->push(vcc, skb);
spin_lock(&he_dev->global_lock);
atomic_inc(&vcc->stats->rx); atomic_inc(&vcc->stats->rx);