iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

of: phy: Only register a phy device for phys

Browse Source 
We will soon support devices other than phys on the mdio bus. Look at
a child's compatibility string to determine if it is a phy, before
registering a phy device.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Andrew Lunn 2016-01-06 20:11:17 +01:00 committed by David S. Miller
parent e5a03bfd87
commit 801a8ef54e
1 changed files with 34 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
drivers/of/of_mdio.c
View File

@ -114,6 +114,35 @@ int of_mdio_parse_addr(struct device *dev, const struct device_node *np)
} }
EXPORT_SYMBOL(of_mdio_parse_addr); EXPORT_SYMBOL(of_mdio_parse_addr);
/*
* Return true if the child node is for a phy. It must either:
* o Compatible string of "ethernet-phy-idX.X"
* o Compatible string of "ethernet-phy-ieee802.3-c45"
* o Compatible string of "ethernet-phy-ieee802.3-c22"
* o No compatibility string
*
* A device which is not a phy is expected to have a compatible string
* indicating what sort of device it is.
*/
static bool of_mdiobus_child_is_phy(struct device_node *child)
{
u32 phy_id;
if (of_get_phy_id(child, &phy_id) != -EINVAL)
return true;
if (of_device_is_compatible(child, "ethernet-phy-ieee802.3-c45"))
return true;
if (of_device_is_compatible(child, "ethernet-phy-ieee802.3-c22"))
return true;
if (!of_find_property(child, "compatible", NULL))
return true;
return false;
}
/** /**
* of_mdiobus_register - Register mii_bus and create PHYs from the device tree * of_mdiobus_register - Register mii_bus and create PHYs from the device tree
* @mdio: pointer to mii_bus structure * @mdio: pointer to mii_bus structure
@ -140,7 +169,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
if (rc) if (rc)
return rc; return rc;
/* Loop over the child nodes and register a phy_device for each one */ /* Loop over the child nodes and register a phy_device for each phy */
for_each_available_child_of_node(np, child) { for_each_available_child_of_node(np, child) {
addr = of_mdio_parse_addr(&mdio->dev, child); addr = of_mdio_parse_addr(&mdio->dev, child);
if (addr < 0) { if (addr < 0) {
@ -148,9 +177,8 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
continue; continue;
} }
rc = of_mdiobus_register_phy(mdio, child, addr); if (of_mdiobus_child_is_phy(child))
if (rc) of_mdiobus_register_phy(mdio, child, addr);
continue;
} }
if (!scanphys) if (!scanphys)
@ -172,9 +200,8 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
dev_info(&mdio->dev, "scan phy %s at address %i\n", dev_info(&mdio->dev, "scan phy %s at address %i\n",
child->name, addr); child->name, addr);
rc = of_mdiobus_register_phy(mdio, child, addr); if (of_mdiobus_child_is_phy(child))
if (rc) of_mdiobus_register_phy(mdio, child, addr);
continue;
} }
} }