iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi_dh_alua: use standard logging functions

Browse Source 
Use standard logging functions instead of hand-crafted ones.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Ewan Milne <emilne@redhat.com>
Reviewed-by: Bart Van Assche <bvanassche@sandisk.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Hannes Reinecke 2015-12-01 10:16:47 +01:00 committed by Martin K. Petersen
parent d3692a3d13
commit 80bd68d6bf
1 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
drivers/scsi/device_handler/scsi_dh_alua.c
View File

@ -23,6 +23,7 @@
#include <linux/delay.h> #include <linux/delay.h>
#include <linux/module.h> #include <linux/module.h>
#include <scsi/scsi.h> #include <scsi/scsi.h>
#include <scsi/scsi_dbg.h>
#include <scsi/scsi_eh.h> #include <scsi/scsi_eh.h>
#include <scsi/scsi_dh.h> #include <scsi/scsi_dh.h>
@ -194,19 +195,14 @@ static void stpg_endio(struct request *req, int error)
if (scsi_normalize_sense(h->sense, SCSI_SENSE_BUFFERSIZE, if (scsi_normalize_sense(h->sense, SCSI_SENSE_BUFFERSIZE,
&sense_hdr)) { &sense_hdr)) {
if (!err) {
err = SCSI_DH_IO;
goto done;
}
err = alua_check_sense(h->sdev, &sense_hdr); err = alua_check_sense(h->sdev, &sense_hdr);
if (err == ADD_TO_MLQUEUE) { if (err == ADD_TO_MLQUEUE) {
err = SCSI_DH_RETRY; err = SCSI_DH_RETRY;
goto done; goto done;
} }
sdev_printk(KERN_INFO, h->sdev, sdev_printk(KERN_INFO, h->sdev, "%s: stpg failed\n",
"%s: stpg sense code: %02x/%02x/%02x\n", ALUA_DH_NAME);
ALUA_DH_NAME, sense_hdr.sense_key, scsi_print_sense_hdr(h->sdev, ALUA_DH_NAME, &sense_hdr);
sense_hdr.asc, sense_hdr.ascq);
err = SCSI_DH_IO; err = SCSI_DH_IO;
} else if (error) } else if (error)
err = SCSI_DH_IO; err = SCSI_DH_IO;
@ -532,13 +528,16 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_dh_data *h, int wait_
} }
err = alua_check_sense(sdev, &sense_hdr); err = alua_check_sense(sdev, &sense_hdr);
if (err == ADD_TO_MLQUEUE && time_before(jiffies, expiry)) if (err == ADD_TO_MLQUEUE && time_before(jiffies, expiry)) {
sdev_printk(KERN_ERR, sdev, "%s: rtpg retry\n",
ALUA_DH_NAME);
scsi_print_sense_hdr(sdev, ALUA_DH_NAME, &sense_hdr);
goto retry; goto retry;
sdev_printk(KERN_INFO, sdev, }
"%s: rtpg sense code %02x/%02x/%02x\n", sdev_printk(KERN_ERR, sdev, "%s: rtpg failed\n",
ALUA_DH_NAME, sense_hdr.sense_key, ALUA_DH_NAME);
sense_hdr.asc, sense_hdr.ascq); scsi_print_sense_hdr(sdev, ALUA_DH_NAME, &sense_hdr);
err = SCSI_DH_IO; return SCSI_DH_IO;
} }
if (err != SCSI_DH_OK) if (err != SCSI_DH_OK)
return err; return err;