iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: comedi: Fix reversed test in comedi_device_attach()

Browse Source 
Commit 3902a370281d2f2b130f141e8cf94eab40125769 (staging: comedi:
refactor comedi_device_attach() a bit) by yours truly introduced an
inverted logic bug in comedi_device_attach() for the case where the
driver expects the device to be configured by driver name rather than
board name.  The result of a strcmp() is being tested incorrectly.  Fix
it.

Thanks to Stephen N Chivers for discovering the bug and suggesting the
fix.

Cc: <stable@vger.kernel.org> # 3.5.x
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ian Abbott 2012-08-14 11:29:17 +01:00 committed by Greg Kroah-Hartman
parent a26f4dd0eb
commit 80eb7a506f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/comedi/drivers.c
View File

@ -168,7 +168,7 @@ int comedi_device_attach(struct comedi_device *dev, struct comedi_devconfig *it)
dev->board_ptr = comedi_recognize(driv, it->board_name); dev->board_ptr = comedi_recognize(driv, it->board_name);
if (dev->board_ptr) if (dev->board_ptr)
break; break;
} else if (strcmp(driv->driver_name, it->board_name)) } else if (strcmp(driv->driver_name, it->board_name) == 0)
break; break;
module_put(driv->module); module_put(driv->module);
} }